Add back Clone() method to the Tree class #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Codecov Report
@@ Coverage Diff @@
## mainline #235 +/- ##
===========================================
Coverage 83.73% 83.73%
Complexity 44 44
===========================================
Files 93 93
Lines 6918 6918
Branches 42 42
===========================================
Hits 5793 5793
Misses 1101 1101
Partials 24 24
Continue to review full report at Codecov.
|
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Jan 7, 2021
Depends on dmlc/treelite#235, dmlc/treelite#236, dmlc/treelite#237, dmlc/treelite#240, dmlc/treelite#241, dmlc/treelite#242, dmlc/treelite#243 Depends on rapidsai/integration#201 Closes #2160 Closes #2795 Closes #2817 TODOs - [x] Get code review for dmlc/treelite#235 and dmlc/treelite#236 and merge them - [x] Get code review for dmlc/treelite#237 and merge them - [x] Merge dmlc/treelite#240, dmlc/treelite#241, dmlc/treelite#242, dmlc/treelite#243 - [x] Run tests locally - [x] Tag a new version of Treelite - [x] Release a new Conda package with the new version tag - [x] Update `meta.yml` and the integration package to use the new Treelite - [x] Run tests (this time build with new Conda package) Authors: - Hyunsu Cho <[email protected]> Approvers: - AJ Schmidt (@ajschmidt8) - William Hicks (@wphicks) - John Zedlewski (@JohnZed) URL: #3316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the recent refactor (#198, #199, #201, and #203) to add support for multiple data types, I accidentally remove the
Clone()method from theTreeclass. This PR adds it back.