Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CMake build; create treelite_runtime Python pkg #167

Merged
merged 18 commits into from
Jun 9, 2020

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Jun 9, 2020

  • Now git submodules are removed.
  • Runtime gets a separate Python package: treelite_runtime.
  • Revamp CMake build script using Modern CMake paradigm.
  • Rewrite setup.py.

@codecov-commenter
Copy link

Codecov Report

Merging #167 into master will increase coverage by 75.93%.
The diff coverage is 83.84%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #167       +/-   ##
=============================================
+ Coverage      9.12%   85.06%   +75.93%     
- Complexity       54       56        +2     
=============================================
  Files            58       58               
  Lines          3681     3642       -39     
  Branches         47       47               
=============================================
+ Hits            336     3098     +2762     
+ Misses         3317      515     -2802     
- Partials         28       29        +1     
Impacted Files Coverage Δ Complexity Δ
include/treelite/compiler.h 100.00% <ø> (+90.00%) 0.00 <0.00> (ø)
include/treelite/compiler_param.h 100.00% <ø> (ø) 0.00 <0.00> (?)
include/treelite/predictor.h 84.37% <ø> (ø) 0.00 <0.00> (?)
include/treelite/tree.h 95.00% <ø> (+87.50%) 0.00 <0.00> (ø)
src/c_api/c_api_runtime.cc 100.00% <ø> (ø) 0.00 <0.00> (?)
src/compiler/native/pred_transform.h 86.20% <ø> (+86.20%) 0.00 <0.00> (ø)
src/frontend/protobuf.cc 88.12% <ø> (+87.65%) 0.00 <0.00> (ø)
src/model.cc 100.00% <ø> (ø) 0.00 <0.00> (?)
src/optable.cc 100.00% <ø> (ø) 0.00 <0.00> (?)
src/predictor/thread_pool/spsc_queue.h 89.18% <ø> (ø) 0.00 <0.00> (?)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c0cb8...dc8c1f2. Read the comment docs.

@hcho3 hcho3 merged commit 44f844c into dmlc:master Jun 9, 2020
@hcho3 hcho3 deleted the refactor_build branch June 9, 2020 22:27
hcho3 added a commit to hcho3/treelite that referenced this pull request Jun 10, 2020
hcho3 added a commit that referenced this pull request Jun 10, 2020
* Remove stray file from #167

* Fix conf.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants