[REVIEW] ENH Refactored cython graph factory code to scale to additional data types #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…louvaincython2dgraphclass
…louvaincython2dgraphclass
…louvaincython2dgraphclass
…ating legacy types and switch statements for it to factory function.
…graphfactoryupdate
…port and upcoming 2D shuffle support
…the MG Louvain test.
… louvain updates to compile.
…graphfactoryupdate, and safety commit: have graph_t Louvain version building and test running (still failing).
…graphfactoryupdate
… ctor. Now having a problem finding the right subcommunicator.
…y subcomms not being initialized: "address not mapped to object at address (nil)"
…endpoints needed for MG test.
…rs to debug in parallel.
…graphfactoryupdate
… (using num edges for partition instead of global for edgelist) and for debugging (print statments).
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
This was referenced Oct 1, 2020
…cythonfactoryrefactoring
…nion members, consolidated legacy enum types, updated comments, initial support added for 64-bit vertex types (untested)
… flag in graph container.
…cythonfactoryrefactoring
rlratzel
changed the title
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.16 #1178 +/- ##
===============================================
- Coverage 57.41% 57.39% -0.03%
===============================================
Files 61 61
Lines 2482 2483 +1
===============================================
Hits 1425 1425
- Misses 1057 1058 +1
Continue to review full report at Codecov.
|
BradReesWork
approved these changes
Oct 2, 2020
ChuckHastings
requested changes
Oct 2, 2020
seunghwak
reviewed
Oct 2, 2020
…on wrapper and removed unnecessary vertex_t/edge_t int64,int32 combinations.
ChuckHastings
approved these changes
Oct 2, 2020
seunghwak
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code originated from @ChuckHastings 's work here: rlratzel#3 (commit: 785ca49)
This update changes the implementation of the cython graph factory code and corresponding container type to allow for easier scaling to different data types. The changes are mostly insulated from clients (the cython wrapper code for each algo) and the client APIs remain almost completely unchanged.
This update is needed to support int64 types needed for graphs with >2B vertices.