-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] ENH Integrate 2D shuffling and latest Louvain API #1163
[REVIEW] ENH Integrate 2D shuffling and latest Louvain API #1163
Conversation
…louvaincython2dgraphclass
…louvaincython2dgraphclass
…louvaincython2dgraphclass
…ating legacy types and switch statements for it to factory function.
…graphfactoryupdate
…port and upcoming 2D shuffle support
…the MG Louvain test.
… louvain updates to compile.
…graphfactoryupdate, and safety commit: have graph_t Louvain version building and test running (still failing).
…graphfactoryupdate
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
…by default, with an option to enable "option 2", temporarily enabled graph expensive checks for debugging.
…one bug in cython code, added copyright to shuffle.py, changed how ranks are retrieved from the raft handle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining things will be addressed in follow on PR. This one is needed to be merged for easier integration with other work.
Codecov Report
@@ Coverage Diff @@
## branch-0.16 #1163 +/- ##
===============================================
- Coverage 57.97% 57.49% -0.48%
===============================================
Files 61 61
Lines 2458 2482 +24
===============================================
+ Hits 1425 1427 +2
- Misses 1033 1055 +22
Continue to review full report at Codecov.
|
…graphfactoryupdate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I guess these are my last complaints :-)
This PR integrates the latest updates to both 2D shuffling and the Louvain C++ work to allow for a complete e2e call from the user API into the Louvain MNMG C++.
closes #1050