Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] ENH Refactored cython graph factory code to scale to additional data types #1178

Merged
merged 48 commits into from
Oct 2, 2020
Merged

[REVIEW] ENH Refactored cython graph factory code to scale to additional data types #1178

merged 48 commits into from
Oct 2, 2020

Commits on Sep 17, 2020

  1. Merge remote-tracking branch 'upstream/branch-0.16' into branch-0.16-… 

    …louvaincython2dgraphclass
    @rlratzel
    rlratzel committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    84bda6a View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/branch-0.16' into branch-0.16-… 

    …louvaincython2dgraphclass
    @rlratzel
    rlratzel committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    9b3e7c2 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. Minor update to comment to describe array sizes.

    @rlratzel
    rlratzel committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    ff4c057 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/branch-0.16' into branch-0.16-… 

    …louvaincython2dgraphclass
    @rlratzel
    rlratzel committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    c6366bb View commit details
    Browse the repository at this point in the history

  3. Changed graph container to use smart pointers, added arg for instanti… 

    …ating legacy types and switch statements for it to factory function.
    @rlratzel
    rlratzel committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    5380bce View commit details
    Browse the repository at this point in the history

  4. Added PR 1152 to CHANGELOG.md

    @rlratzel
    rlratzel committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    4cb0605 View commit details
    Browse the repository at this point in the history

  5. Removing unnecessary .get() call on unique_ptr instance

    @rlratzel
    rlratzel committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    c5a73f6 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2020

  1. Using make_unique() instead of new

    @rlratzel
    rlratzel committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    00fae18 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Updated to call drop() correctly after cudf API update.

    @rlratzel
    rlratzel committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    41f6229 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. Added args to support calling get_vertex_identifiers().

    @rlratzel
    rlratzel committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    d014688 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/branch-0.16' into branch-0.16-… 

    …graphfactoryupdate
    @rlratzel
    rlratzel committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    2730530 View commit details
    Browse the repository at this point in the history

  3. Style fixes, removed commented out code meant for a future change.

    @rlratzel
    rlratzel committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    1df91bb View commit details
    Browse the repository at this point in the history

  4. Updated comment with description of new 'identifiers' arg.

    @rlratzel
    rlratzel committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    a5e99f8 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2020

  1. Safety commit, still WIP, does not compile - updates for 2D graph sup… 

    …port and upcoming 2D shuffle support
    @rlratzel
    rlratzel committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    8b9d4f6 View commit details
    Browse the repository at this point in the history

  2. safety commit, does not pass tests: updated enough to be able to run … 

    …the MG Louvain test.
    @rlratzel
    rlratzel committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    de1dc73 View commit details
    Browse the repository at this point in the history

  3. Updated call_louvain() to use the new graph_t types. Still WIP, needs… 

    … louvain updates to compile.
    @rlratzel
    rlratzel committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    296a245 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/branch-0.16' into branch-0.16-… 

    …graphfactoryupdate, and safety commit: have graph_t Louvain version building and test running (still failing).
    @rlratzel
    rlratzel committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    e29309b View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/branch-0.16' into branch-0.16-… 

    …graphfactoryupdate
    @rlratzel
    rlratzel committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    5f68114 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2020

  1. WIP: updates for incorporating new 2D shuffle data, still does not pa… 

    …ss test.
    @rlratzel
    rlratzel committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    6c7d282 View commit details
    Browse the repository at this point in the history

  2. Adding updates from iroy30 for calling shuffle from louvain.py

    @rlratzel
    rlratzel committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    44a894d View commit details
    Browse the repository at this point in the history

  3. Updated to extract and pass the partition_t info and call the graph_t… 

    … ctor. Now having a problem finding the right subcommunicator.
    @rlratzel
    rlratzel committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    e8d8401 View commit details
    Browse the repository at this point in the history

  4. Updates to set up subcomms - having a problem with something needed b… 

    …y subcomms not being initialized: "address not mapped to object at address (nil)"
    @rlratzel
    rlratzel committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    03c8ffb View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. Added p2p flag to comms initialize() to enable initialization of UCX … 

    …endpoints needed for MG test.
    @rlratzel
    rlratzel committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    48ab522 View commit details
    Browse the repository at this point in the history

  2. some proposed cleanup

    @ChuckHastings
    ChuckHastings committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    eb81b7a View commit details
    Browse the repository at this point in the history

  3. safety commit: committing with debug prints to allow other team membe… 

    …rs to debug in parallel.
    @rlratzel
    rlratzel committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    736d3ff View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/branch-0.16' into branch-0.16-… 

    …graphfactoryupdate
    @rlratzel
    rlratzel committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    51bdff8 View commit details
    Browse the repository at this point in the history

  5. new technique for factory

    @ChuckHastings
    ChuckHastings committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    785ca49 View commit details
    Browse the repository at this point in the history

  6. safety commit: more updates to address problems instantiating graph_t… 

    … (using num edges for partition instead of global for edgelist) and for debugging (print statments).
    @rlratzel
    rlratzel committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    9c998ec View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. Changing how row and col rank are obtained, added debug prints for ed… 

    …ge lists info
    @rlratzel
    rlratzel committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    edead12 View commit details
    Browse the repository at this point in the history

  2. Fixes to partition_t get_matrix_partition_major/minor methods based o… 

    …n feedback.
    @rlratzel
    rlratzel committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    e543ea8 View commit details
    Browse the repository at this point in the history

  3. Update shuffle.py

    @Iroy30
    Iroy30 authored Sep 30, 2020
    Configuration menu
    Copy the full SHA
    8f14bab View commit details
    Browse the repository at this point in the history

  4. Integrating changes from iroy30 to produce "option 1" shuffle output … 

    …by default, with an option to enable "option 2", temporarily enabled graph expensive checks for debugging.
    @rlratzel
    rlratzel committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    8b03b91 View commit details
    Browse the repository at this point in the history

  5. Addressed review feedback: made var names consistent, fixed weights=N… 

    …one bug in cython code, added copyright to shuffle.py, changed how ranks are retrieved from the raft handle.
    @rlratzel
    rlratzel committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    584e9b3 View commit details
    Browse the repository at this point in the history

  6. Removed debug prints.

    @rlratzel
    rlratzel committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    6b9480a View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/branch-0.16' into branch-0.16-… 

    …graphfactoryupdate
    @rlratzel
    rlratzel committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    6225bfe View commit details
    Browse the repository at this point in the history

  8. Added PR 1163 to CHANGELOG.md

    @rlratzel
    rlratzel committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    0a5b3fd View commit details
    Browse the repository at this point in the history

  9. Removed extra newlines accidentally added to clean up diff in the PR,… 

    … updated comment in cython code.
    @rlratzel
    rlratzel committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    22e3829 View commit details
    Browse the repository at this point in the history

  10. Added specific newlines back so file does not differ unnecessarily.

    @rlratzel
    rlratzel committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    b59c9e1 View commit details
    Browse the repository at this point in the history

  11. Disabled graph_t expensive check that was left enabled for debugging.

    @rlratzel
    rlratzel committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    b017e96 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Merge remote-tracking branch 'upstream/branch-0.16' into branch-0.16-… 

    …graphfactoryupdate
    @rlratzel
    rlratzel committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    da6a50c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'ChuckHastings/chuck_update' into branch… 

    …-0.16-cythonfactoryrefactoring

Updated cython factory utils and louvain cython code to match recent updates to main branch.
Still WIP, need to ensure legacy tests pass.
    @rlratzel
    rlratzel committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    1e877ec View commit details
    Browse the repository at this point in the history

  3. Added code path in call_louvain to support legacy graph types, to be … 

    …removed when migration to graph_t types is complete.
    @rlratzel
    rlratzel committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    b6b175a View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/branch-0.16' into branch-0.16-… 

    …cythonfactoryrefactoring
    @rlratzel
    rlratzel committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    5d06b48 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Updates based on feedback from PR 1163: code cleanup/removed unused u… 

    …nion members, consolidated legacy enum types, updated comments, initial support added for 64-bit vertex types (untested)
    @rlratzel
    rlratzel committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    5da2729 View commit details
    Browse the repository at this point in the history

  2. plumbed bool set based on running renumbering to set sorted_by_degree… 

    … flag in graph container.
    @rlratzel
    rlratzel committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    2f2ae1d View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/branch-0.16' into branch-0.16-… 

    …cythonfactoryrefactoring
    @rlratzel
    rlratzel committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    6eef915 View commit details
    Browse the repository at this point in the history

  4. Added PR 1178 to CHANGELOG.md, C++ style fixes.

    @rlratzel
    rlratzel committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    6f50786 View commit details
    Browse the repository at this point in the history

  5. Addressed PR review feedback: added support for proper edge_t in cyth… 

    …on wrapper and removed unnecessary vertex_t/edge_t int64,int32 combinations.
    @rlratzel
    rlratzel committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    5adb743 View commit details
    Browse the repository at this point in the history