-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor lists::contains
#11019
Refactor lists::contains
#11019
Conversation
This PR updates `clamp.cu` to take templated iterator types by value. This aligns the style with the rest of libcudf. See also: #11019 (comment) Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Nghia Truong (https://github.com/ttnghia) - David Wendt (https://github.com/davidwendt) - Mark Harris (https://github.com/harrism) URL: #11084
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. This has improved a lot with review.
Thanks all for reviewing. Yeah, the implementation has been improved significantly with your help ❤️ |
# Conflicts: # cpp/src/lists/contains.cu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments. Rest look good. 👍
@gpucibot merge |
This extends the `lists::contains` API to support nested types (lists + structs) with arbitrarily nested levels. As such, `lists::contains` will work with literally any type of input data. In addition, the related implementation has been significantly refactored to facilitate adding new implementation. Closes #8958. Depends on: * #10730 * #10883 * #10999 * #11019 * #11037 Authors: - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) Approvers: - MithunR (https://github.com/mythrocks) - Bradley Dice (https://github.com/bdice) URL: #10548
This is just a not-very-simple refactor to
lists::contains
:lists/contains.hpp
, and rewrite doxygen there a little bit.No new feature is added in this PR, just modifying the existing functions and moving things around.
This PR is extracted from the bigger PR for easier review. The original PR is #10548 for supporting nested type in
lists::contains
. As such, this blocks it.