-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] support lists::contains on lists of structs. #8958
Comments
This issue has been labeled |
This issue has been labeled |
This is still wanted. Not a huge priority though |
Blocked by hash refactoring. I'm still investigating it. |
This will be solved trivially by #10186 |
@revans2 I think we should better support trivial |
This extends the `lists::contains` API to support nested types (lists + structs) with arbitrarily nested levels. As such, `lists::contains` will work with literally any type of input data. In addition, the related implementation has been significantly refactored to facilitate adding new implementation. Closes #8958. Depends on: * #10730 * #10883 * #10999 * #11019 * #11037 Authors: - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) Approvers: - MithunR (https://github.com/mythrocks) - Bradley Dice (https://github.com/bdice) URL: #10548
Is your feature request related to a problem? Please describe.
We would like to extend the
lists::contains
function to support lists of structs and list of more deeply nested structs, like a struct with structs in it. We are prioritizing structs right now, and this is not intended to cover structs that also contain lists.Just like with the existing code if the input value is a null or if the search value is a null, then the output should also be a null.
Describe the solution you'd like
Have
lists::contains
just work.Describe alternatives you've considered
We could try and hack this together ourselves by picking apart the child columns and then checking for equality for each of them, with and-ing them all together followed by a reduction, but that gets really complicated.
The text was updated successfully, but these errors were encountered: