Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add Java bindings for CSV reading with data_type schema #9062

Closed
jlowe opened this issue Aug 18, 2021 · 2 comments · Fixed by #9066
Closed

[FEA] Add Java bindings for CSV reading with data_type schema #9062

jlowe opened this issue Aug 18, 2021 · 2 comments · Fixed by #9066
Assignees
@revans2
Labels
feature request New feature or request Java Affects Java cuDF API.

Comments

@jlowe
Copy link
Member

jlowe commented Aug 18, 2021

Is your feature request related to a problem? Please describe.
#8240 is removing the ability to specify data types for CSV reading as strings. Currently the Java bindings for CSV reading only support passing strings for the data types.

Describe the solution you'd like
The Java bindings should add a Table.readCSV method that takes the data schema to read as an array of DType rather than strings.
@jlowe jlowe added feature request New feature or request Needs Triage Need team to review and classify Java Affects Java cuDF API. labels Aug 18, 2021
@jlowe jlowe mentioned this issue Aug 18, 2021
Closed
@revans2 revans2 self-assigned this Aug 18, 2021
@revans2
Copy link
Contributor

revans2 commented Aug 18, 2021

I have a patch for this, but the last time I tried to do it I ran into some bugs. I will try to resurrect that patch and verify that the bugs have been fixed.

@revans2 revans2 removed the Needs Triage Need team to review and classify label Aug 18, 2021
@revans2
Copy link
Contributor

revans2 commented Aug 18, 2021 •
edited
Loading

The bug I found is still open #8613 I'll see if it is still a problem.

@revans2 revans2 mentioned this issue Aug 18, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Aug 19, 2021
@revans2
Update JNI java CSV APIs to not use deprecated API (#9066)
53f0bb4 
This fixes #9062

Authors:
  - Robert (Bobby) Evans (https://github.com/revans2)

Approvers:
  - Jason Lowe (https://github.com/jlowe)

URL: #9066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revans2 revans2

Labels
feature request New feature or request Java Affects Java cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update JNI java CSV APIs to not use deprecated API revans2/cudf
2 participants
@jlowe @revans2