Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CSV parsing throws when filtering columns using data_types API #8613

Closed
revans2 opened this issue Jun 25, 2021 · 4 comments
Closed

[BUG] CSV parsing throws when filtering columns using data_types API #8613

revans2 opened this issue Jun 25, 2021 · 4 comments
Assignees
Labels
bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code.

Comments

@revans2
Copy link
Contributor

revans2 commented Jun 25, 2021

Describe the bug
The way to set the data types expect when parsing CSV is changing. The old API which is deprecated took a string to indicate how to parse it. The new API takes a data_type. However when I tried to switch the java API over to use this new API I started to get exceptions and even a seg fault in one case.

Steps/Code to reproduce bug
Apply the attached patch and run the CSV tests.

tests.patch.gz

Expected behavior
The tests pass, or at least don't crash in scary ways. It is not clear from the docs if the semantics of the API also changed or not, but if they did and I am passing in the wrong things a descriptive error message would be a lot better.

@revans2 revans2 added bug Something isn't working Needs Triage Need team to review and classify labels Jun 25, 2021
@revans2
Copy link
Contributor Author

revans2 commented Jun 25, 2021

This appears to only happen when only some of the columns are being read, and others are filtered out.

@beckernick beckernick added cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Jul 23, 2021
@vuule vuule self-assigned this Aug 18, 2021
@revans2
Copy link
Contributor Author

revans2 commented Aug 18, 2021

I upmerged my original patch and it looks like this may have already been fixed. I will run through a full set of tests to verify it though.

@vuule
Copy link
Contributor

vuule commented Aug 18, 2021

I did fix a few bugs in the original implementation, so hopefully that's it.

@revans2
Copy link
Contributor Author

revans2 commented Aug 18, 2021

Yup all of my tests passed so I am just going to close this

@revans2 revans2 closed this as completed Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

No branches or pull requests

3 participants