Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JNI java CSV APIs to not use deprecated API #9066

Merged
merged 3 commits into from
Aug 19, 2021

Conversation

revans2
Copy link
Contributor

@revans2 revans2 commented Aug 18, 2021

This fixes #9062

@revans2 revans2 added 3 - Ready for Review Ready for review by team code quality Java Affects Java cuDF API. non-breaking Non-breaking change labels Aug 18, 2021
@revans2 revans2 self-assigned this Aug 18, 2021
@revans2 revans2 requested a review from a team as a code owner August 18, 2021 17:48
@revans2 revans2 added the improvement Improvement / enhancement to an existing function label Aug 18, 2021
@jlowe jlowe added breaking Breaking change and removed non-breaking Non-breaking change labels Aug 18, 2021
@jlowe jlowe linked an issue Aug 18, 2021 that may be closed by this pull request
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked this as a breaking change since it removes DType#getSimpleName.

@revans2
Copy link
Contributor Author

revans2 commented Aug 18, 2021

I marked this as a breaking change since it removes DType#getSimpleName.

Good catch. That API was never supposed to be public, but I guess I missed it when it when it.

@revans2
Copy link
Contributor Author

revans2 commented Aug 18, 2021

Build failure looks like it is related to AST changes in #9045. I'll try to upmerge and see what happens.

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@04b7027). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 9d3750b differs from pull request most recent head 12e455f. Consider uploading reports for the commit 12e455f to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9066   +/-   ##
===============================================
  Coverage                ?   10.71%           
===============================================
  Files                   ?      114           
  Lines                   ?    19097           
  Branches                ?        0           
===============================================
  Hits                    ?     2046           
  Misses                  ?    17051           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04b7027...12e455f. Read the comment docs.

@revans2
Copy link
Contributor Author

revans2 commented Aug 19, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 53f0bb4 into rapidsai:branch-21.10 Aug 19, 2021
@revans2 revans2 deleted the jni_cvs_api_deprecation branch August 19, 2021 12:52
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond breaking Breaking change improvement Improvement / enhancement to an existing function Java Affects Java cuDF API.
Projects
None yet
3 participants