-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] gather list of decimal values now fails #7441
Comments
revans2
added
bug
Something isn't working
Needs Triage
Need team to review and classify
labels
Feb 24, 2021
revans2
changed the title
[BUG] filtering decimal values now fails
[BUG] gather list of decimal values now fails
Feb 24, 2021
diff --git a/cpp/tests/copying/gather_list_tests.cu b/cpp/tests/copying/gather_list_tests.cu
index 59f696c440..ac6524b94e 100644
--- a/cpp/tests/copying/gather_list_tests.cu
+++ b/cpp/tests/copying/gather_list_tests.cu
@@ -35,6 +35,7 @@ template <typename T>
class GatherTestListTyped : public cudf::test::BaseFixture {
};
using FixedWidthTypesNotBool = cudf::test::Concat<cudf::test::IntegralTypesNotBool,
+ cudf::test::FixedPointTypes,
cudf::test::FloatingPointTypes,
cudf::test::DurationTypes,
cudf::test::TimestampTypes>; reproduces the problem we are seeing. with results like
I have verified that all of the tests pass if I revert 2234554 |
kkraus14
added
libcudf
Affects libcudf (C++/CUDA) code.
and removed
Needs Triage
Need team to review and classify
labels
Feb 24, 2021
I have the fix and pushed a PR: #7449. Should be unblocked once this is merged. |
rapids-bot bot
pushed a commit
that referenced
this issue
Feb 25, 2021
) Resolves #7441 Missed a necessary change to `type_dispatcher` invocation in `/lists/copyting/gather.cu` in #7419 Authors: - Conor Hoekstra (@codereport) Approvers: - David (@davidwendt) - @nvdbaranec - Robert (Bobby) Evans (@revans2) URL: #7449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The Apache spark plugin started to see test failures in out integration test builds last night NVIDIA/spark-rapids#1802. I was able to git bisect to find that 2234554 (#7419) caused the issues to show up. I have not traced it down to a specific API yet, but from the tests it appears that gather for an array of decimal values is returning no data, but I am not 100% sure on that. I will try to track it down further.
Steps/Code to reproduce bug
Right now it is the spark SQL integration tests, but I will try to come up with a reproducible C++ test. some time soon. Not sure if #7419 is required or just a nice to have, but this is blocking a lot of Spark plugin work right now.
The text was updated successfully, but these errors were encountered: