Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] gather list of decimal values now fails #7441

Closed
revans2 opened this issue Feb 24, 2021 · 2 comments · Fixed by #7449
Closed

[BUG] gather list of decimal values now fails #7441

revans2 opened this issue Feb 24, 2021 · 2 comments · Fixed by #7449
Assignees
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS

Comments

@revans2
Copy link
Contributor

revans2 commented Feb 24, 2021

Describe the bug
The Apache spark plugin started to see test failures in out integration test builds last night NVIDIA/spark-rapids#1802. I was able to git bisect to find that 2234554 (#7419) caused the issues to show up. I have not traced it down to a specific API yet, but from the tests it appears that gather for an array of decimal values is returning no data, but I am not 100% sure on that. I will try to track it down further.

Steps/Code to reproduce bug
Right now it is the spark SQL integration tests, but I will try to come up with a reproducible C++ test. some time soon. Not sure if #7419 is required or just a nice to have, but this is blocking a lot of Spark plugin work right now.

@revans2 revans2 added bug Something isn't working Needs Triage Need team to review and classify labels Feb 24, 2021
@revans2 revans2 changed the title [BUG] filtering decimal values now fails [BUG] gather list of decimal values now fails Feb 24, 2021
@revans2
Copy link
Contributor Author

revans2 commented Feb 24, 2021

diff --git a/cpp/tests/copying/gather_list_tests.cu b/cpp/tests/copying/gather_list_tests.cu
index 59f696c440..ac6524b94e 100644
--- a/cpp/tests/copying/gather_list_tests.cu
+++ b/cpp/tests/copying/gather_list_tests.cu
@@ -35,6 +35,7 @@ template <typename T>
 class GatherTestListTyped : public cudf::test::BaseFixture {
 };
 using FixedWidthTypesNotBool = cudf::test::Concat<cudf::test::IntegralTypesNotBool,
+                                                  cudf::test::FixedPointTypes,
                                                   cudf::test::FloatingPointTypes,
                                                   cudf::test::DurationTypes,
                                                   cudf::test::TimestampTypes>;

reproduces the problem we are seeing. with results like

[ RUN      ] GatherTestListTyped/9.GatherDetailInvalidIndex
../tests/utilities/column_utilities.cu:225: Failure
Failed
depth 2
first difference: lhs[1] = 21474836483, rhs[1] = 3
Google Test trace:
../tests/copying/gather_list_tests.cu:280:  <--  line of failure

[  FAILED  ] GatherTestListTyped/9.GatherDetailInvalidIndex, where TypeParam = numeric::fixed_point<long, (numeric::Radix)10> (1 ms)
[ RUN      ] GatherTestListTyped/9.GatherSliced
../tests/utilities/column_utilities.cu:225: Failure
Failed
depth 2
first difference: lhs[0] = 4, rhs[0] = 7
../tests/utilities/column_utilities.cu:225: Failure
Failed
depth 2
first difference: lhs[0] = 10, rhs[0] = 6
../tests/utilities/column_utilities.cu:225: Failure
Failed
depth 3
first difference: lhs[2] = 30, rhs[2] = 40
../tests/utilities/column_utilities.cu:225: Failure
Failed
depth 3
first difference: lhs[0] = 10, rhs[0] = 0
[  FAILED  ] GatherTestListTyped/9.GatherSliced, where TypeParam = numeric::fixed_point<long, (numeric::Radix)10> (8 ms)

I have verified that all of the tests pass if I revert 2234554

@kkraus14 kkraus14 added libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Feb 24, 2021
@jlowe jlowe added the Spark Functionality that helps Spark RAPIDS label Feb 24, 2021
@codereport
Copy link
Contributor

I have the fix and pushed a PR: #7449. Should be unblocked once this is merged.

@codereport codereport self-assigned this Feb 25, 2021
rapids-bot bot pushed a commit that referenced this issue Feb 25, 2021
)

Resolves #7441

Missed a necessary change to `type_dispatcher` invocation in `/lists/copyting/gather.cu` in #7419

Authors:
  - Conor Hoekstra (@codereport)

Approvers:
  - David (@davidwendt)
  - @nvdbaranec
  - Robert (Bobby) Evans (@revans2)

URL: #7449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants