-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify type dispatch with device_storage_dispatch
#7419
Simplify type dispatch with device_storage_dispatch
#7419
Conversation
Do you have any measurements of the impact of this change on compile time or binary size? |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7419 +/- ##
==============================================
Coverage ? 82.23%
==============================================
Files ? 101
Lines ? 17060
Branches ? 0
==============================================
Hits ? 14029
Misses ? 3031
Partials ? 0 Continue to review full report at Codecov.
|
Compile time no, I will post when I measure. Binary size doesn't seem to have changed (based on current commits)
|
Compile times:
Binary sizes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. You may need to update some copyrights.
Welp, so much for that idea. Either the compiler was already making the optimization or the switch is just too complicated to detect the identical instantiations. Anyways, I still think this is a clean way to handle the storage type. Thanks for doing this. |
I agree, I still think this is a lot cleaner for the cases that work. All you have to do is find the |
@gpucibot merge |
) Resolves #7441 Missed a necessary change to `type_dispatcher` invocation in `/lists/copyting/gather.cu` in #7419 Authors: - Conor Hoekstra (@codereport) Approvers: - David (@davidwendt) - @nvdbaranec - Robert (Bobby) Evans (@revans2) URL: #7449
Resolves #7390
Compile times:
Binary sizes: