Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Many decimal integration test failures for 0.5 #1802

Closed
jlowe opened this issue Feb 24, 2021 · 7 comments · Fixed by #1807
Closed

[BUG] Many decimal integration test failures for 0.5 #1802

jlowe opened this issue Feb 24, 2021 · 7 comments · Fixed by #1807
Assignees
Labels
bug Something isn't working

Comments

@jlowe
Copy link
Member

jlowe commented Feb 24, 2021

A number of unit tests failed on Databricks for the 0.5 nightly integration tests. Some excerpts:

01:01:19  =========================== short test summary info ============================
01:01:19  FAILED ../../src/main/python/array_test.py::test_orderby_array_unique[Array(Decimal(7,-3))]
01:01:19  FAILED ../../src/main/python/array_test.py::test_orderby_array_unique[Array(Decimal(7,7))]
01:01:19  FAILED ../../src/main/python/array_test.py::test_orderby_array_unique[Array(Decimal(7,3))]
01:01:19  FAILED ../../src/main/python/array_test.py::test_orderby_array_unique[Array(Decimal(12,2))]
01:01:19  FAILED ../../src/main/python/array_test.py::test_orderby_array_unique[Array(Decimal(18,0))]
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_dropna_any[Array(Decimal(7,-3))]
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_dropna_any[Array(Decimal(18,0))]
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_dropna_any[Array(Decimal(7,7))]
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_dropna_all[Array(Decimal(7,-3))]
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_dropna_any[Array(Decimal(7,3))]
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_dropna_all[Array(Decimal(7,3))]
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_dropna_any[Array(Decimal(12,2))]
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_dropna_all[Array(Decimal(7,7))]
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_dropna_all[Array(Decimal(18,0))]
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_filter[Array(Decimal(7,7))] - ...
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_dropna_all[Array(Decimal(12,2))]
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_filter[Array(Decimal(7,3))] - ...
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_filter[Array(Decimal(7,-3))]
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_filter[Array(Decimal(18,0))]
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_filter_with_project[Array(Decimal(7,-3))]
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_filter_with_project[Array(Decimal(7,7))]
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_filter[Array(Decimal(12,2))]
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_filter_with_project[Array(Decimal(12,2))]
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_filter_with_project[Array(Decimal(7,3))]
01:01:19  FAILED ../../src/main/python/cmp_test.py::test_filter_with_project[Array(Decimal(18,0))]
01:01:19  FAILED ../../src/main/python/window_function_test.py::test_window_aggs_for_rows_collect_list_no_nulls[IGNORE_ORDER({'local': True})]
@jlowe jlowe added bug Something isn't working ? - Needs Triage Need team to review and classify labels Feb 24, 2021
@jlowe
Copy link
Member Author

jlowe commented Feb 24, 2021

Detailed log of test errors:
test_errors.txt

@revans2 revans2 self-assigned this Feb 24, 2021
@revans2
Copy link
Collaborator

revans2 commented Feb 24, 2021

All of these tests just failed for me in a pre-commit build for 0.5. It feels almost like there is a change in cudf that is causing this I am going to try and track down what is happening.

@revans2
Copy link
Collaborator

revans2 commented Feb 24, 2021

Yup I was able to reproduce the failures on the bast 0.5 branch locally.

@revans2
Copy link
Collaborator

revans2 commented Feb 24, 2021

I went back a couple of days on the plugin and it still fails, this looks very much like a cudf issue.

@jlowe jlowe changed the title [BUG] Many decimal integration test failures for 0.5 on Databricks [BUG] Many decimal integration test failures for 0.5 Feb 24, 2021
@revans2
Copy link
Collaborator

revans2 commented Feb 24, 2021

Yup when I got back to 43b44e1 in cudf all of the tests pass again. I will start to track down the change that caused this to happen

@jlowe
Copy link
Member Author

jlowe commented Feb 25, 2021

This should be fixed when rapidsai/cudf#7449 is merged and a new cudf-0.19 snapshot is published.

@jlowe jlowe removed the ? - Needs Triage Need team to review and classify label Feb 25, 2021
@revans2
Copy link
Collaborator

revans2 commented Feb 26, 2021

Dependency is merged and tests appear to be passing.

@revans2 revans2 closed this as completed Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants