-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Fix header order issue in device_operators.cuh
#5746
Comments
device_operators.cuh
device_operators.cuh
Hi there! @codereport, I tried to reproduce this issue but it seems that the issue has been fixed somehow. Can you or somebody verify that, please? |
Hi @ttnghia, thanks for pointing this out. Looks like somewere along the way the issue self resolved. I have set up #7401 to remove the comment and will take the bug label off this issue. |
This resolves #5746 (seems like the issue self resolved, just removing now unnecessary comment and clang-formatting). Authors: - Conor Hoekstra (@codereport) Approvers: - David (@davidwendt) - Jake Hemstad (@jrhemstad) - Mike Wilson (@hyperbolic2346) URL: #7401
In the #5704, an issue was discovered with the order of the headers included in the file. The issue discussed in the following comment thread: #5704 (comment) It seems like it has to do with Jitify requiring
<simt/type_traits>
while other files just depend on<type_traits>
but the conflict seems to occur from includingfixed_point.hpp
beforeutilities/traits.hpp
. This issue is being set up so that the root of this conflict can be addressed and resolved at a later date. Below is a list of some of the files dependency hierarchies:device_operators.cuh
#include <cudf/fixed_point/fixed_point.hpp>
--------#include <simt/limits>
--------#include <simt/type_traits> // add simt namespace
--------#include
--------#include
--------#include
--------#include
#include <cudf/utilities/traits.hpp>
--------#include <cudf/strings/string_view.cuh>
----------------#include <cuda_runtime.h>
----------------#include
----------------#include <cudf/types.hpp>
----------------#include
----------------#include "./string_view.inl"
----------------#include <thrust/find.h>
------------------------#include
--------#include <cudf/lists/list_view.cuh>
--------#include <cudf/types.hpp>
--------#include <cudf/utilities/type_dispatcher.hpp>
--------#include <cudf/wrappers/durations.hpp>
--------#include <cudf/wrappers/timestamps.hpp>
--------#include <simt/type_traits>
#include <cudf/scalar/scalar.hpp>
--------#include <cudf/types.hpp>
--------#include <cudf/utilities/traits.hpp>
--------#include <cudf/utilities/type_dispatcher.hpp>
-------- #include <rmm/thrust_rmm_allocator.h>
--------#include <rmm/device_buffer.hpp>
--------#include <rmm/device_scalar.hpp>
--------#include
--------#include <type_traits> <- was ABLE TO DELETE
--------#include
--------#include
#include <cudf/types.hpp>
#include <cudf/utilities/error.hpp>
#include <simt/type_traits>
#include <type_traits> <- ORIGINALLY
type.cpp (jit)
#include <cudf/column/column_view.hpp>
#include <cudf/scalar/scalar.hpp>
#include <cudf/utilities/type_dispatcher.hpp>
#include
The text was updated successfully, but these errors were encountered: