Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix header order issue in device_operators.cuh #5746

Closed
codereport opened this issue Jul 23, 2020 · 2 comments · Fixed by #7401
Closed

[BUG] Fix header order issue in device_operators.cuh #5746

codereport opened this issue Jul 23, 2020 · 2 comments · Fixed by #7401
Assignees
Labels
libcudf Affects libcudf (C++/CUDA) code.

Comments

@codereport
Copy link
Contributor

In the #5704, an issue was discovered with the order of the headers included in the file. The issue discussed in the following comment thread: #5704 (comment) It seems like it has to do with Jitify requiring <simt/type_traits> while other files just depend on <type_traits> but the conflict seems to occur from including fixed_point.hpp before utilities/traits.hpp. This issue is being set up so that the root of this conflict can be addressed and resolved at a later date. Below is a list of some of the files dependency hierarchies:

device_operators.cuh

#include <cudf/fixed_point/fixed_point.hpp>
--------#include <simt/limits>
--------#include <simt/type_traits> // add simt namespace
--------#include
--------#include
--------#include
--------#include

#include <cudf/utilities/traits.hpp>
--------#include <cudf/strings/string_view.cuh>
----------------#include <cuda_runtime.h>
----------------#include
----------------#include <cudf/types.hpp>
----------------#include
----------------#include "./string_view.inl"
----------------#include <thrust/find.h>
------------------------#include
--------#include <cudf/lists/list_view.cuh>
--------#include <cudf/types.hpp>
--------#include <cudf/utilities/type_dispatcher.hpp>
--------#include <cudf/wrappers/durations.hpp>
--------#include <cudf/wrappers/timestamps.hpp>
--------#include <simt/type_traits>

#include <cudf/scalar/scalar.hpp>
--------#include <cudf/types.hpp>
--------#include <cudf/utilities/traits.hpp>
--------#include <cudf/utilities/type_dispatcher.hpp>
-------- #include <rmm/thrust_rmm_allocator.h>
--------#include <rmm/device_buffer.hpp>
--------#include <rmm/device_scalar.hpp>

--------#include
--------#include <type_traits> <- was ABLE TO DELETE
--------#include
--------#include

#include <cudf/types.hpp>
#include <cudf/utilities/error.hpp>

#include <simt/type_traits>
#include <type_traits> <- ORIGINALLY

type.cpp (jit)

#include <cudf/column/column_view.hpp>
#include <cudf/scalar/scalar.hpp>
#include <cudf/utilities/type_dispatcher.hpp>
#include

@codereport codereport added feature request New feature or request Needs Triage Need team to review and classify labels Jul 23, 2020
@kkraus14 kkraus14 added bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify feature request New feature or request labels Aug 5, 2020
@kkraus14 kkraus14 changed the title [FEA] Fix header order issue in device_operators.cuh [BUG] Fix header order issue in device_operators.cuh Aug 5, 2020
@ttnghia
Copy link
Contributor

ttnghia commented Feb 16, 2021

Hi there!

@codereport, I tried to reproduce this issue but it seems that the issue has been fixed somehow. Can you or somebody verify that, please?

@codereport
Copy link
Contributor Author

Hi there!

@codereport, I tried to reproduce this issue but it seems that the issue has been fixed somehow. Can you or somebody verify that, please?

Hi @ttnghia, thanks for pointing this out. Looks like somewere along the way the issue self resolved. I have set up #7401 to remove the comment and will take the bug label off this issue.

@codereport codereport removed the bug Something isn't working label Feb 17, 2021
@codereport codereport self-assigned this Feb 17, 2021
rapids-bot bot pushed a commit that referenced this issue Feb 17, 2021
This resolves #5746 (seems like the issue self resolved, just removing now unnecessary comment and clang-formatting).

Authors:
  - Conor Hoekstra (@codereport)

Approvers:
  - David (@davidwendt)
  - Jake Hemstad (@jrhemstad)
  - Mike Wilson (@hyperbolic2346)

URL: #7401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants