Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up included headers in device_operators.cuh #7401

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Clean up included headers in device_operators.cuh #7401

merged 2 commits into from
Feb 17, 2021

Conversation

codereport
Copy link
Contributor

This resolves #5746 (seems like the issue self resolved, just removing now unnecessary comment and clang-formatting).

@codereport codereport added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 17, 2021
@codereport codereport self-assigned this Feb 17, 2021
@codereport codereport requested a review from a team as a code owner February 17, 2021 16:25
@codereport codereport mentioned this pull request Feb 17, 2021
Closed
@codereport codereport added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Feb 17, 2021
@codereport
Copy link
Contributor Author

@gpucibot merge

@codecov
Copy link

codecov bot commented Feb 17, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.19@b090d96). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.19    #7401   +/-   ##
==============================================
  Coverage               ?   82.21%           
==============================================
  Files                  ?      100           
  Lines                  ?    16971           
  Branches               ?        0           
==============================================
  Hits                   ?    13953           
  Misses                 ?     3018           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b090d96...5cb2744. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 846e6b6 into rapidsai:branch-0.19 Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@jrhemstad jrhemstad jrhemstad approved these changes

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt

@harrism harrism Awaiting requested review from harrism

Assignees

@codereport codereport

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Fix header order issue in device_operators.cuh
4 participants
@codereport @hyperbolic2346 @jrhemstad @davidwendt