Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Initial fixed_point Column Support #5704

Merged
merged 82 commits into from
Jul 31, 2020

Conversation

codereport
Copy link
Contributor

@codereport codereport commented Jul 16, 2020

This is part 1 of adding support for fixed_point columns. The follow up PR will:

  • Add scale_type into data_type
  • Hook up the thrust::transform_input_output_iterator
  • Customize allocation factory functions (to only allocate for underlying value)

Still to do for this PR:

  • Disable support for certain algorithms
  • Add numeric::decimal64 and corresponding code
  • Make unit tests general to include decimal64
  • Get binaryop working for decimal64

@codereport codereport added the 4 - Needs Review Waiting for reviewer to review or respond label Jul 29, 2020
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @codereport ! Just add that one comment about why simt::std in fixed_point.hpp, otherwise good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants