Rebase Rancher Desktop fork of Steve #7
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds logic to ensure that only one schema/access set is cached for each user. This should improve memory consumption
Adds tests for: - Cache clearing functionality - Very basic schema generation
Adding logic to limit number of cached schemas
Three main changes: - When a count changes, only send that count. This makes the count socket significantly more usable - The count buffer will now send a count right away. This allows a message to launch wihtout an inital buffered wait period - The count buffer now sends messages every 5 seconds instead of 1
Adds a validate phase to the CI which runs a linter. Also fixes linter issues discovered during the initial run
Steve Pipeline, Go Version updates
Remove duplicate import and make aliasing of other apiserver imports consistent throughout steve.
HandlerFromConfig was not used in steve or rancher.
The header defined in RFC 9110[1] is "Accept", not "Accepts". This change corrects the route filter. Since this API is not documented and the header was plainly incorrect, no attempt is made at backwards compatibility. [1] https://www.rfc-editor.org/rfc/rfc9110.html#name-accept
Usage of the switchstore store was removed when the clusters resource was removed in dcea1db.
The use of AddNamespaceConstraint was removed in e35b8304 of rancher/rancher, so there is no possibility of there being a namespace constraint in the request context. Remove the unused function and the unused codepath from the rbac store.
Updated logic used to decide when and what schema events are sent during a watch.
Cleanup and docs
Updates Schemas watch logic.
Changing view links
Bumps dynamic listener to v0.3.5. Adds a small arg change to account for this version bump which addresses an issue caused by the new version
Bump dynamic listener to v0.3.5
Changing count watch to only return changed counts
Filtering and sorting needs to operate on unstructured data. It also needs to operate after the parallel partitioner, higher in the store stack. This means that the proxy Store needs to return raw, unstructured data up to the partitioner. This change moves all conversions from unstructured Kubernetes types to apiserver objects up from the proxy store into the partitioner.
Co-authored-by: Tom Lebreux <[email protected]>
Migrate from Drone to GHA
This uses SQLite-backed informers provided by Lasso with rancher/lasso#65 to implement Steve API (/v1/) functionality. This new functionality is available behind a feature flag to be specified at Steve startup See https://confluence.suse.com/pages/viewpage.action?pageId=1359086083 Co-authored-by: Ricardo Weir <[email protected]> Co-authored-by: Michael Bolot <[email protected]> Co-authored-by: Silvio Moioli <[email protected]> Signed-off-by: Silvio Moioli <[email protected]>
also updated k8s dependencies to v0.30.1
k8s 1.30 dependencies update
Prior schema calculations started with openapiv2 models which included a model for APIGroups. However, new schema calculations use ServerGroupsAndResources first, which omitted these values. This re-adds this type using a static schema.
Adding APIGroups back to the schema
Signed-off-by: Silvio Moioli <[email protected]>
Signed-off-by: Silvio Moioli <[email protected]>
* sql: drop dead code Signed-off-by: Silvio Moioli <[email protected]> * sql: bugfix: return total resource count correctly Signed-off-by: Silvio Moioli <[email protected]> * adapt tests Signed-off-by: Silvio Moioli <[email protected]> * adapt mocks Signed-off-by: Silvio Moioli <[email protected]> * TEMP: remove this when bumping lasso to include rancher/lasso#84 Signed-off-by: Silvio Moioli <[email protected]> * Use latest lasso instead of fork --------- Signed-off-by: Silvio Moioli <[email protected]> Co-authored-by: Tom Lebreux <[email protected]>
and other dependencies that also bumps wrangler
Signed-off-by: Phillip Rak <[email protected]>
Otherwise, default to dynamic to keep behavior the same as it is today Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: phillip_rak <[email protected]>
Signed-off-by: phillip_rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Darren Shepherd <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
This resolves an error raised by the linter ``` Error: pkg/ui/routes.go:27:2: ineffectual assignment to path (ineffassign) path, err := filepath.Abs(r.URL.Path) ``` Signed-off-by: Phillip Rak <[email protected]>
rak-phillip
force-pushed
the
chore/steve-rebase
branch
from
bd55b9a
to
9321a37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.