Cleanup and docs #60
Cleanup and docs #60
Conversation
There was a problem hiding this comment.
Thanks for adding comments to a lot of this stuff.
I have some concerns about changing exported functions/interfaces on a non-major release. I'd prefer we not do this (or that we tag the code after this is merged as v1.0.0) - as we are not the only users of steve.
One other note - your CI is going to fail until #59 goes in. If you want it to pass, you can update a specific part of the .drone.yml to fix that - see here for what you need to add.
|
@MbolotSuse I disagree about changing exported functions. steve does not follow semver. It does not even have releases. We don't make any guarantees of backwards compatibility. I've checked in harvester and throughout github and nothing is using these functions and packages. If I missed something, someone can file an issue and it is easy to revert. But I don't think trying to live up to an idealistic standard of API compatibility is helpful to us. It is more beneficial to clean up cruft because this helps us maintain the code in the long run. |
|
Discussed offline - since Steve doesn't currently follow a versioning strategy, there's no incentive for us to preserve functionality between changes. Especially when the functionality isn't being used by other areas. |
Remove duplicate import and make aliasing of other apiserver imports consistent throughout steve.
HandlerFromConfig was not used in steve or rancher.
The header defined in RFC 9110[1] is "Accept", not "Accepts". This change corrects the route filter. Since this API is not documented and the header was plainly incorrect, no attempt is made at backwards compatibility. [1] https://www.rfc-editor.org/rfc/rfc9110.html#name-accept
Usage of the switchstore store was removed when the clusters resource was removed in dcea1db.
The use of AddNamespaceConstraint was removed in e35b8304 of rancher/rancher, so there is no possibility of there being a namespace constraint in the request context. Remove the unused function and the unused codepath from the rbac store.
|
rebased |
Partially addresses rancher/rancher#38593