-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: bugfix: return total resource count correctly #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Silvio Moioli <[email protected]>
Signed-off-by: Silvio Moioli <[email protected]>
Signed-off-by: Silvio Moioli <[email protected]>
Signed-off-by: Silvio Moioli <[email protected]>
Signed-off-by: Silvio Moioli <[email protected]>
This was referenced Jul 5, 2024
JFYI @richard-cox @brudnak |
MbolotSuse
reviewed
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending the lasso changes to complete the work.
tomleb
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just gotta make sure to update lasso first
MbolotSuse
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: when browsing to a paginated list, pagination controls do not appear at the bottom of the page:
Root cause: Steve is returning the total resource count incorrectly (returning the number of returned resources, usually one page size or less, instead of the total count).
Solution: leverage new data returned by lasso with rancher/lasso#83 to return the right number.
Note this PR should be merged together with rancher/lasso#83 or functionality will break.
Result: pagination controls appear and work as expected:
FWIW I have also run the integration tests and they are all green rancher/rancher#46015
Best reviewed commit-by-commit.
Please note this contains commits from #235, disregard the first commit.
Please note this PR should be merged after https://github.com/rancher/lasso/84, and the last TEMP commit should be replaced with a lasso bump. The TEMP commit is there to show that tests pass once both changes are merged.