-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devnet): runtime non-fungible pallet (basic standard features) #261
Closed
chungquantin
wants to merge
14
commits into
chungquantin/api-non_fungibles
from
chungquatin/runtime-non_fungibles
Closed
feat(devnet): runtime non-fungible pallet (basic standard features) #261
chungquantin
wants to merge
14
commits into
chungquantin/api-non_fungibles
from
chungquatin/runtime-non_fungibles
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## chungquantin/api-non_fungibles #261 +/- ##
==================================================================
+ Coverage 34.10% 38.94% +4.84%
==================================================================
Files 34 37 +3
Lines 3011 3276 +265
Branches 3011 3276 +265
==================================================================
+ Hits 1027 1276 +249
- Misses 1952 1972 +20
+ Partials 32 28 -4
|
chungquantin
changed the title
feat(devnet): runtime non-fungible pallet
feat(devnet): runtime non-fungible pallet (basic standard features)
Sep 6, 2024
owned_in_collection {
let i in 0 .. 5_000;
let (collection, caller, _) = create_collection::<T, I>();
let items = (0..i).map(|x| mint_item::<T, I>(x as u16).0).collect::<Vec<_>>();
} : {
Nfts::<T, I>::owned_in_collection(&collection, &caller)
} Weight benchmarking result for /// The range of component `i` is `[0, 5000]`.
fn owned_in_collection(i: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
// Minimum execution time: 2_000_000 picoseconds.
Weight::from_parts(3_905_593, 0)
// Standard Error: 26
.saturating_add(Weight::from_parts(469, 0).saturating_mul(i.into()))
} cc: @Daanvdplas |
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime first implementation of the local non-fungible use case. Deliverables include:
non-fungibles
implementation following the spec feat: local non-fungible use cases #259 to provide both read and write methods.Important
Questionable approach in the
allowance
method that currently forks the relevant structs toItemDetail
. The purpose of this is to get the fieldapprovals
(which is a privatefield
in a private structItemDetail
) by decoding.Note
Will need to design this API to be compatible with
v1.14.0
inmain
, currentlyv1.7.0
indaan/api