-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: local non-fungible use cases #259
Comments
My concerns for this specification is should we support collection (introduce in the trait crate If we agree to support collection creation / item management, we will need to make some adjustments to the specification of the PSP34. For collection item, we can follow PSP34, for collection we will come up with our own cc: @Daanvdplas @peterwht |
Please use the PSP34 spec from here: https://github.com/inkdevhub/standards/tree/master/PSPs (slightly more up-to-date) |
Here is also a good reference implementation: https://github.com/Cardinal-Cryptography/PSP34 (note, it is on ink! v4.3.0, so there are some improvements with ink! v5) |
I would remove the ERC-721 milestone for now. It can remain in the spec if you want, but I don't think we should prioritize its implementation. We should have a base And then, the remaining functionality listed in |
Yes, we should definitely support this. |
Implement the non-fungible feature to
pop-api
to support interact with non-fungible tokens.Basic Specification
PSP34Mintable Interface
WRITE API METHODS
Important
Contract mints the collection item to the designated account
PSP34Burnable Interface
WRITE API METHODS
Important
Only the owner of the collection item has the authority to destroy it
PSP34 Interface
Because PSP34 is a standard for a non-fungible token. We need to adjust it a bit to support collectable use cases:
READ API METHODS
Warning
Got a blocker because there is no method supported in the
pallet-nfts
to retrieve theapprovals
information of an item. One way is to fork theItemDetail
struct and encode on our own to retrieve the fieldapprovals
(this field isprivate
in thepallet-nfts
)WRITE API METHODS
PSP34Metadata Interface
WRITE API METHODS
READ API METHODS
PSP34Enumerable
READ API METHODS
Extensions
[Proposed] PSP34Admin
WRITE API METHODS
Important
Remove the witness data parameter and handle the witness date in the pallet logic instead.
[Proposed] PSP34Swappable
TBA
[Proposed] PSP34Ownanle
WRITE API METHODS
The text was updated successfully, but these errors were encountered: