-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nfts): add nonfungibles runtime implementation #339
Open
chungquantin
wants to merge
18
commits into
chungquantin/chore-pallet_nfts
Choose a base branch
from
chungquantin/feat-nonfungibles
base: chungquantin/chore-pallet_nfts
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(nfts): add nonfungibles runtime implementation #339
chungquantin
wants to merge
18
commits into
chungquantin/chore-pallet_nfts
from
chungquantin/feat-nonfungibles
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
chungquantin
changed the title
feat: add nonfungibles pallet implementation
feat(devnet): add nonfungibles pallet implementation
Oct 14, 2024
8 tasks
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #339 +/- ##
==========================================
+ Coverage 51.60% 53.85% +2.24%
==========================================
Files 48 51 +3
Lines 4910 5205 +295
Branches 4910 5205 +295
==========================================
+ Hits 2534 2803 +269
- Misses 2327 2343 +16
- Partials 49 59 +10
|
chungquantin
changed the base branch from
main
to
chungquantin/chore-pallet_nfts
October 14, 2024 15:25
chungquantin
force-pushed
the
chungquantin/feat-nonfungibles
branch
from
October 15, 2024 09:54
74ccaa7
to
8832470
Compare
chungquantin
changed the title
feat(devnet): add nonfungibles pallet implementation
feat(devnet): add nonfungibles runtime implementation
Oct 17, 2024
chungquantin
changed the title
feat(devnet): add nonfungibles runtime implementation
feat(nfts): add nonfungibles runtime implementation
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the runtime pallet
pallet-api/nonfungibles
for the #259. This implementation follows the discussed NFT spec with the forkedpallet-nfts
.pallet-nfts
AccountBalance
: Keep track of the total number of collection items an account has.Allowances
: Keep track of the collection approval status for a delegated account.AccountBalance
] Update existing methods' logicdo_transfer
: Increase account balance ofsender
and decrease account balance ofdest
on transferred.do_mint
: Increase account balance ofminter
on minted.do_burn
: Decrease account balance ofowner
on burnt.Allowances
] Update existing methods' logicpallet-api/nonfungibles
pallet-api/nonfungibles
.pallet-nfts
andpallet-api/nonfungibles
toTest
runtime inmock.rs
pallet-api/fungibles
to use an updatedAccount
instead ofu8
. (.e.g,account(ALICE)
)pallet-nonfungibles
.devnet
. Merge this PR first: refactor: generic extension #218