-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nonfungibles): add pallet-api/nonfungibles
#388
base: chungquantin/feat-nfts
Are you sure you want to change the base?
feat(nonfungibles): add pallet-api/nonfungibles
#388
Conversation
pallet-api/nonfungibles
pallet-api/nonfungibles
/// The namespace of the attribute. | ||
namespace: AttributeNamespaceOf<T>, | ||
/// The key of the attribute. | ||
key: BoundedVec<u8, T::KeyLimit>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this parameter be changed to Vec and we handle the length check in the runtime, so contract api implementation does not need to handle it?
config: CollectionConfigFor<T>, | ||
) -> DispatchResult { | ||
let creator = ensure_signed(origin.clone())?; | ||
// TODO: re-evaluate next collection id in nfts pallet. The `Incrementable` trait causes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this TODO be tackled in this PR?
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## chungquantin/feat-nfts #388 +/- ##
==========================================================
+ Coverage 69.57% 71.42% +1.84%
==========================================================
Files 69 73 +4
Lines 12222 13394 +1172
Branches 12222 13394 +1172
==========================================================
+ Hits 8504 9566 +1062
- Misses 3448 3545 +97
- Partials 270 283 +13
... and 3 files with indirect coverage changes 🚨 Try these New Features:
|
Description
Implement the runtime pallet
pallet-api/nonfungibles
for the #259. This implementation follows the discussed NFT spec with the forkedpallet-nfts
.Linked PRs
Pallet:
pallet-api/nonfungibles
pallet-api/nonfungibles
.pallet-nfts
andpallet-api/nonfungibles
toTest
runtime inmock.rs
pallet-api/fungibles
to use an updatedAccount
instead ofu8
. (.e.g,account(ALICE)
)pallet-nonfungibles
.