Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macOS R-devel travis config for testing 4.0.0 #1885

Merged
merged 5 commits into from
Apr 29, 2020
Merged

Update macOS R-devel travis config for testing 4.0.0 #1885

merged 5 commits into from
Apr 29, 2020

Conversation

coatless
Copy link
Contributor

@coatless coatless commented Apr 2, 2020

This PR updates the toolchain to use:

As noted in:

https://stat.ethz.ch/pipermail/r-sig-mac/2020-April/013289.html

And addressed further in:

https://stat.ethz.ch/pipermail/r-sig-mac/2020-April/013311.html


What wasn't done is implement a pull of binaries available here:

http://mac.r-project.org/libs-4/

Note: There is a machine-readable list in http://mac.r-project.org/libs-4/INDEX

Would this be appreciated?

@coatless
Copy link
Contributor Author

coatless commented Apr 3, 2020

An error is being triggered due to this unit test:

should include_sexp [:cmd, %r{^curl.*mac\.r-project\.org/el-capitan/R-devel/R-devel-el-capitan\.pkg},
assert: true, echo: true, retry: true, timing: true]

I'll change it to the appropriate URL that was updated above.

lib/travis/build/script/r.rb Outdated Show resolved Hide resolved
spec/build/script/r_spec.rb Outdated Show resolved Hide resolved
@jimhester
Copy link
Contributor

LGTM

@jeroen
Copy link
Contributor

jeroen commented Apr 10, 2020

@BanzaiMan lgtm 🚀

Copy link
Contributor

@jeroen jeroen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, thanks!

@BanzaiMan
Copy link
Contributor

@jeroen Sorry, I overlooked this before merging #1901. Is it safe to merge this on top?

@jeroen
Copy link
Contributor

jeroen commented Apr 29, 2020

@BanzaiMan yes that's safe, they only overlap a bit.

@BanzaiMan BanzaiMan merged commit 1dfae95 into travis-ci:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants