Test #1
Closed
Test #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves oras-project#510 --------- Signed-off-by: Billy Zha <[email protected]>
…roject#520) https://github.com/opencontainers/image-spec/blob/v1.0/image-layout.md#content specifies that the blobs dir must exist, so the changed ensureDir in this PR is a bugfix. The addition and use of the ociBlobsDir constant is more of a cleanup suggestion, and I can remove it if necessary. I've also asked for it to be added upstream at opencontainers/image-spec#1069 but that will probably take significantly longer. Signed-off-by: Clarence "Sparr" Risher <[email protected]>
NewWithContext refers to both the `oci-layout` and `index.json` as "OCI Image Layout", this PR fixes the latter. ReadAll is a deeper change that will improve error reporting for a lot of cases, at the cost of error volume. Some or all of that change could happen higher up to satisfy this particular issue. I think the expected/actual size output belongs here. There seem to be more than a few code paths in this and other repos that end up calling ReadAll multiple times without reporting which call produced an error so I think it's appropriate to also output the digest here, but that's less compelling. The Verify comment clears up confusion I encountered while working on this issue. "verifies size" implies checking for both too big AND too small, but it only checks if the file is bigger (or reader is longer) than expected. Fixes oras-project#432 Signed-off-by: Clarence "Sparr" Risher <[email protected]>
…ng types (oras-project#536) Resolves: oras-project#530 Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Resolves: oras-project#531 Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
…m to image-spec v1.1.0-rc4 (oras-project#550) 1. Introduce `PackOptions.PackManifestType` 2. Introduce `DefaultPackOptions` Resolves: oras-project#532 Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
…ject#553) Resolves: oras-project#443 Resolves: oras-project#533 Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
…spec v1.1.0-rc3 (oras-project#557) 1. Support pushing image index with a subject 2. Check the "OCI-Subject" header Resolves: oras-project#534 Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
…-spec v1.1.0-rc3 (oras-project#558) Support deleting image indexes with a subject Resolves: oras-project#535 Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Resolves: oras-project#554 Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Add `Repository.HandleWarning(Warning)` that handles encountered warning headers. Resolves: oras-project#469 Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Resolves oras-project#434 Signed-off-by: Xiaoxuan Wang <[email protected]>
Following up issue oras-project#434 Signed-off-by: Xiaoxuan Wang <[email protected]>
…s-project#565) Related issue: oras-project#532 Related discussion: oras-project/oras#1011 (comment) Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
This PR refactors `oras.Pack` that was updated by oras-project#532. 1. Move the support of Image Manifest `v1.1.0-rc4` to `PackManifest` 2. Deprecate `Pack` Resolves: oras-project#568 Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
…t#574) Resolves: oras-project#571 Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Terry Howe <[email protected]>
1. Update go mod version to `1.20` 2. Update go version matrix in workflow config files 3. Update README Resolves: oras-project#583 --------- Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
…as-project#589) 1. Add package `credentials` (migrated from [`oras-credentials-go`](https://github.com/oras-project/oras-credentials-go)) and its corresponding description 2. Add new type `auth.CredentialFunc` 3. Migrate the credentials example from [oras.land](https://oras.land/docs/client_libraries/go/#pull-an-image-using-the-docker-credential-store) 4. Change `auth.DefaultCache` to `auth.NewCache()` in examples Resolves: oras-project#584 Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
…errersGC (oras-project#593) Fix: oras-project#592 Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Features: - Add `MemoryStore` I submitted a pull request for MemoryStore to `oras-credentials-go` a week ago. However, the repository has since been deprecated. I've created an identical PR to [this one](oras-project/oras-credentials-go#92). Reference Issue: [Here](oras-project/oras-credentials-go#89) Signed-off-by: Uanid <[email protected]>
…roject#605) 1. Un-expose `credentials.MemoryStore` as it is unecessary to be public 2. Make `credentials.NewMemoryStore` return an interface instead of a struct Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Closes oras-project#600 Signed-off-by: Kyle M. Tarplee <[email protected]>
Fix: oras-project#552 Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
The purpose of this PR is to fix the bug, but new APIs are needed to avoid breaking changes. 1. Introduce `auth.WithScopesForHost` 2. Introduce `auth.AppendScopesForHost` 3. Introduce `auth.GetScopesForHost` and `auth.GetAllScopesForHost` 4. Introduce `auth.AppendRepositoryScope` Resolves: oras-project#581 Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Part 2/4 of oras-project#454 Based on draft PR oras-project#582 --------- Signed-off-by: Xiaoxuan Wang <[email protected]> Co-authored-by: Terry Howe <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]> Part 3/4 of oras-project#454 Based on draft PR oras-project#582 --------- Signed-off-by: Xiaoxuan Wang <[email protected]>
…ras-project#615) 1. Bump `github.com/opencontainers/image-spec` to `v1.1.0-rc5` in go mod 2. Replace "index.json" and "blobs" with corresponding constants in the spec 3. Fix testable examples that broke by the spec change - `MediaType` became a required field in `Descriptor` Resolve: oras-project#599 Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
…ig (oras-project#617) Fix: oras-project#616 --------- Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]> Part 1/4 of oras-project#454 Based on draft PR oras-project#582 Current behavior regarding `graph.Memory.Remove(node)`: * `node` entry in `m.successors` and `m.nodes` is removed. * `node` is removed from its successors predecessors list. * `node` entry in `m.predecessors` is NOT removed, **unless all its predecessors no longer exist**. * `node` is NOT removed from its predecessors' `m.successors` list. The `m.successors` is always in accordance with the actual content. Signed-off-by: Xiaoxuan Wang <[email protected]>
Add `pull` and `delete` scope hints before attempting client-side indexing on manifest delete. Resolve: oras-project#594 Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
resolves oras-project#626 Signed-off-by: Xiaoxuan Wang <[email protected]>
Include values of the artifact and or related context in the errors - This is related to oras-project/oras#1152. See the oras-project/oras#1152 to see the updates to output of errors. Signed-off-by: Sajay Antony <[email protected]>
…t#631) Export `ErrSkipDesc` as `ErrSkipDesc` allows users of the library to implement `CopyGraphOptions.PreCopy` to call `Mount()` and then return `ErrSkipDesc` from `PreCopy` which bypasses the downstream copy operation. Closes oras-project#580 Signed-off-by: Kyle M. Tarplee <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.