-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 76.08% 76.86% +0.78%
==========================================
Files 7 8 +1
Lines 414 428 +14
==========================================
+ Hits 315 329 +14
Misses 77 77
Partials 22 22
|
Signed-off-by: Uanid <[email protected]>
Signed-off-by: Uanid <[email protected]>
Signed-off-by: Uanid <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit
@shizhMSFT Could you take a look as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with suggestions
inmemory_store.go
Outdated
) | ||
|
||
// InMemoryStore is a store that keeps credentials in memory. | ||
type InMemoryStore struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be better to name it MemoryStore
instead of InMemoryStore
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That might be a good name. Changed it to MemoryStore.
Co-authored-by: Lixia (Sylvia) Lei <[email protected]> Signed-off-by: Minuk Song <[email protected]>
Signed-off-by: Uanid <[email protected]>
Signed-off-by: Uanid <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged. Thank you @uanid again for contributing this! |
Features: - Add `MemoryStore` I submitted a pull request for MemoryStore to `oras-credentials-go` a week ago. However, the repository has since been deprecated. I've created an identical PR to [this one](oras-project/oras-credentials-go#92). Reference Issue: [Here](oras-project/oras-credentials-go#89) Signed-off-by: Uanid <[email protected]>
Features:
MemoryStore
Reference Issue: #89