Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge oras-credentials-go back #584

Closed
Wwwsylvia opened this issue Sep 4, 2023 · 0 comments · Fixed by #589
Closed

Merge oras-credentials-go back #584

Wwwsylvia opened this issue Sep 4, 2023 · 0 comments · Fixed by #589
Assignees
@Wwwsylvia
Labels
enhancement New feature or request
Milestone
v2.4.0

Comments

@Wwwsylvia
Copy link
Member

As oras-credentials-go has now reached a fairly stable state, we can proceed with merging it back into oras-go. This will allows us:

  1. Reduce maintenance cost
  2. Include credentials package in oras-go as an incremental feature with no dependency penalty
  3. Increase visibility of oras-credentials-go as a package in oras-go

See oras-project/oras-credentials-go#80 for more details.
@Wwwsylvia Wwwsylvia added the enhancement New feature or request label Sep 4, 2023
@Wwwsylvia Wwwsylvia added this to the v2.4.0 milestone Sep 4, 2023
@Wwwsylvia Wwwsylvia mentioned this issue Sep 6, 2023
Merged
Wwwsylvia added a commit that referenced this issue Sep 8, 2023
@Wwwsylvia
feat: merge package credentials back from oras-credentials-go (#589)
c130949 
1. Add package `credentials` (migrated from
[`oras-credentials-go`](https://github.com/oras-project/oras-credentials-go))
and its corresponding description
2. Add new type `auth.CredentialFunc`
3. Migrate the credentials example from
[oras.land](https://oras.land/docs/client_libraries/go/#pull-an-image-using-the-docker-credential-store)
4. Change `auth.DefaultCache` to `auth.NewCache()` in examples

Resolves: #584
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wwwsylvia Wwwsylvia

Labels
enhancement New feature or request
Projects
ORAS Project Board-2023
Status: Done
Milestone
v2.4.0
Development

Successfully merging a pull request may close this issue.

feat: merge package credentials back from oras-credentials-go Wwwsylvia/oras-go
1 participant
@Wwwsylvia