ORM/Panache: rely on ORM getResultCount #41619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this callback should send a binary message
- remove experimenal annotations and exclamations from the docs - extract the documentation in a separate file
There are several issues: - first, the config doc processor is part of the extension processor for now, so you need to run it to analyze the config. - second we need to mark at least one class with @ConfigMapping, otherwise the config groups cannot be analyzed as part of config mappings. This will go away in the future. - then, the hierarchy here is quite weird with some methods overriding others, which is fine, except this is not properly handled in the config doc generator. For now, I just ignored the ones from the parent, but ideally, we should override them properly in the config doc generator. - also I removed some inherited methods from GrafanaConfig and I'm not yet sure if it will break something so creating as draft.
Corrected name in FrontendResource parameter
…named-config Resolve conditional dependencies using named configurations instead of detached ones
…gnore Kafka dependabot config : Ignore major and minor updates
0-9 is accepted too.
WebSockets Next: fix OnOpen callback that returns Buffer/byte[]
…he default source for the Gradle plugin
improve test reliability et the expense of test time fix quarkusio#41298
…cy-test-flaky-41298 Fix odic token retrieval under concurrency test flakiness
QuarkusComponentTest: remove experimental status
Bump to Mutiny 2.6.1 and Mutiny Vert.x bindings 3.13.1
WebSockets Next: document the client API
Document TLS configuration for WebSockets Next
Add support to prefix for envFrom
WebSockets Next: fire CDI events for client connections added/removed
Bumps org.jboss.resteasy.spring:resteasy-spring-web from 3.1.2.Final to 3.1.3.Final. --- updated-dependencies: - dependency-name: org.jboss.resteasy.spring:resteasy-spring-web dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Make the identifier error message consistent with the rules
…g.jboss.resteasy.spring-resteasy-spring-web-3.1.3.Final Bump org.jboss.resteasy.spring:resteasy-spring-web from 3.1.2.Final to 3.1.3.Final
quarkus-bot
bot
added
area/lra
area/mailer
area/maven
area/metrics
area/mongodb
area/mutiny
area/narayana
|
🙈 The PR is closed and the preview is expired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to not care about which parameters are set on the count query, since order by parameters are ignored by ORM. Which is not the case if we write our own count query.
Note that this is not yet available in HR, so we have to keep the count query logic around until that's available.
Fixes #40962
This requires ORM 6.5.3 for https://hibernate.atlassian.net/browse/HHH-18234
Also requires HR supporting getResultCount hibernate/hibernate-reactive#1932
Supercedes #41019