ORM/Panache: rely on ORM getResultCount #41019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to not care about which parameters are set on the count query, since `order by` parameters are ignored by ORM. Which is not the case if we write our own count query. Note that this is not yet available in HR, so we have to keep the count query logic around until that's available. Fixes #40962
|
What was pushed? |
You created the branch on the main repo, not on your fork: https://github.com/quarkusio/quarkus/tree/40962 |
|
Oh, oops. OK, lemme fix that, and rebase. |
This was referenced Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to not care about which parameters are set on the count query, since
order byparameters are ignored by ORM. Which is not the case if we write our own count query.Note that this is not yet available in HR, so we have to keep the count query logic around until that's available.
Fixes #40962
This requires ORM 6.5.3 for https://hibernate.atlassian.net/browse/HHH-18234
Also requires HR supporting
getResultCounthibernate/hibernate-reactive#1932