Add support to prefix for envFrom

[mcruzdev]

• Fixes Kubernetes extension: Support env vars from secrets with a prefix #38604

We need to wait the release of new https://github.com/dekorateio/dekorate version

[gsmet]

Converting to draft as it's using a snapshot version.

[mcruzdev]

Hi @gsmet I think that we can review now, thank you @iocanel for release the dekorate version :)

[mcruzdev]

I will fix the import sort soon...

[github-actions]

🙈 The PR is closed and the preview is expired.

[mcruzdev]

@gsmet, should this change be on separated pull request?

[geoand]

@metacosm I assume the version bump is fine with you?

[metacosm]

I actually don't know and didn't get a chance to check… That version of dekorate uses an older sundrio version than the one used in the Kubernetes client and I have no idea about compatibility. I would have preferred this upgrade to be isolated from this PR if at all possible and be consulted before merging it, as is mentioned in the POM file.

[geoand]

Fair enough.

When you get please chance, please check the version and see if everything works as expected.

Thanks!

[mcruzdev]

This was necessary because dekorate did not support prefix for env, I had to implement this on the dekorate side.

dekorateio/dekorate#1289

Without this version, this PR breaks.

[metacosm]

Hi @metacosm, to do this one will be necessary to change the EnvVarsConfig POJO.

Removing the List<String> secrets and adding something like mapping Map<String, EnvVarFromKeyConfig> mapping;.

The secrets will need a change:

From: quarkus.kubernetes.env.secrets=my-secret,my-other-secret to:

quarkus.kubernetes.env.secrets.my-secret.name=my-secret
quarkus.kubernetes.env.secrets.my-secret.prefix=DBZ_

or you can follow what @iocanel suggested!

Let me know if I am wrong 😃

You're right.

Maybe we could use the mapping configuration to our advantage here, though, with something like:

quarkus.kubernetes.env.mapping."DB1_".as-prefix-for-secret=my-secret
quarkus.kubernetes.env.mapping."CM1_".as-prefix-for-configmap=my-cm

[mcruzdev]

Hi @metacosm Sorry for delay... I am back now :)

I think that using this one:

quarkus.kubernetes.env.mapping."DB1_".as-prefix-for-secret=my-secret

We need to set the with-key property to use, like this:

quarkus.kubernetes.env.mapping."DB1_".with-key=secret-key-here

It means that to set the prefix we need to set the with-key. two properties to set the prefix, what do you think about @iocanel suggestion?

quarkus.kubernetes.env.prefix."MY_PREFIX_".fromSecret=my-secret

[metacosm]

It means that to set the prefix we need to set the with-key. two properties to set the prefix, what do you think about @iocanel suggestion?

You're right again :)

quarkus.kubernetes.env.prefix."MY_PREFIX_".fromSecret=my-secret

I guess that's indeed the best solution but then I'd do:

quarkus.kubernetes.env.prefixes."MY_PREFIX_".for-secret=my-secret

If we wanted to be more fluent, we could do:

quarkus.kubernetes.env.using."MY_PREFIX_".as-prefix-for-secret=my-secret

but I guess that would be less legible on the ConfigGroup in the code…

[mcruzdev]

I loved the last sample!

quarkus.kubernetes.env.using."MY_PREFIX_".as-prefix-for-secret

But as I said, I think that:

quarkus.kubernetes.env.prefixes."MY_PREFIX_".for-secret=my-secret

Is better for both (customer and code)

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 58575e7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 integration-tests/reactive-messaging-kafka

✖ io.quarkus.it.kafka.KafkaConnectorTest.testFruits - History

• Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testFruits(KafkaConnectorTest.java:63)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

---

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/oidc-client-wiremock

✖ io.quarkus.it.keycloak.OidcClientTest.testEchoAndRefreshTokensWithConcurrency - History

• Assertion condition defined as a Lambda expression in io.quarkus.it.keycloak.OidcClientTest null within 2 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.keycloak.OidcClientTest null within 2 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.keycloak.OidcClientTest.testEchoAndRefreshTokensWithConcurrency(OidcClientTest.java:125)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

[geoand]

@iocanel can you have a look at this?

Thanks

[iocanel]

LGTM