Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.13] Handle duplicated context in the CacheResultInterceptor #37225

Merged

Conversation

cescoffier
Copy link
Member

@cescoffier cescoffier commented Nov 20, 2023

Backport of #37077

  • Capture the context when calling the interceptor
  • Make sure the item is emitted on the captured context

@cescoffier cescoffier changed the base branch from main to 2.13 November 20, 2023 15:23
Copy link

quarkus-bot bot commented Nov 20, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

Backport of quarkusio#37077

* Capture the context when calling the interceptor
* Make sure the item is emitted on the captured context
@cescoffier cescoffier force-pushed the 2.13-duplicated-context-cache-interceptor branch from f052cc8 to d0363a7 Compare November 20, 2023 15:26
@cescoffier cescoffier marked this pull request as ready for review November 20, 2023 15:26
@gsmet gsmet added this to the 2.13.9.Final milestone Nov 20, 2023
Copy link

quarkus-bot bot commented Nov 20, 2023

Failing Jobs - Building d0363a7

Status Name Step Failures Logs Raw logs Build scan
✔️ Gradle Tests - JDK 11 🚧
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs 🚧

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.ConditionalDependenciesTest.scenarioTwo line 147 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting path:

io.quarkus.gradle.TestFixtureModuleTest.testTaskShouldUseTestFixtures line 19 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

Expecting value to be true but was false

@gsmet gsmet merged commit 90c1558 into quarkusio:2.13 Nov 20, 2023
58 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants