Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle duplicated context in the CacheResultInterceptor #37077

Merged

Conversation

cescoffier
Copy link
Member

  • Capture the context when calling the interceptor
  • Make sure the item is emitted on the captured context

@cescoffier
Copy link
Member Author

Waiting for @vsevel confirmation.

@cescoffier cescoffier requested a review from vsevel November 14, 2023 13:11
Copy link
Member

@gwenneg gwenneg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vsevel
Copy link
Contributor

vsevel commented Nov 14, 2023

I will validate it this afternoon, tomorrow at the latest

This comment has been minimized.

@mschorsch
Copy link
Contributor

Will this be backported?

@cescoffier
Copy link
Member Author

@mschorsch yes. but we are waiting for a confirmation first.

- Capture the context when calling the interceptor
- Make sure the item is emitted on the captured context
@cescoffier cescoffier force-pushed the handle-duplicated-context-in-cache-result branch from f98313b to f781b7f Compare November 15, 2023 10:37
Copy link

quarkus-bot bot commented Nov 15, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@vsevel
Copy link
Contributor

vsevel commented Nov 15, 2023

I confirm this is working as expected. great work @cescoffier !

@geoand geoand merged commit d9ace85 into quarkusio:main Nov 15, 2023
23 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Nov 15, 2023
@gsmet gsmet modified the milestones: 3.7 - main, 3.5.2 Nov 15, 2023
@cescoffier cescoffier deleted the handle-duplicated-context-in-cache-result branch November 16, 2023 06:57
@aloubyansky aloubyansky modified the milestones: 3.5.2, 3.2.9.Final Nov 16, 2023
@sberyozkin
Copy link
Member

Please remove a backport to 2.13 label if it is not relevant

cescoffier added a commit to cescoffier/quarkus that referenced this pull request Nov 20, 2023
Backport of quarkusio#37077

* Capture the context when calling the interceptor
* Make sure the item is emitted on the captured context
cescoffier added a commit to cescoffier/quarkus that referenced this pull request Nov 20, 2023
Backport of quarkusio#37077

* Capture the context when calling the interceptor
* Make sure the item is emitted on the captured context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants