Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ignore invalid config in quarkus.container-image.name #33560

Merged
merged 1 commit into from
May 23, 2023
Merged

Don't ignore invalid config in quarkus.container-image.name #33560

merged 1 commit into from
May 23, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented May 23, 2023

Fixes: #33552

@geoand geoand requested a review from radcortez May 23, 2023 14:41
@geoand geoand mentioned this pull request May 23, 2023
Closed
machi1990
machi1990 reviewed May 23, 2023
View reviewed changes
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change lgtm. Can we add a unit test?

@geoand
Copy link
Contributor Author

geoand commented May 23, 2023 •
edited
Loading

Sure, I'll add that tomorrow Test added

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 23, 2023
machi1990
machi1990 approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks @geoand

@geoand
Copy link
Contributor Author

geoand commented May 23, 2023

🙏

@quarkus-bot
Copy link

quarkus-bot bot commented May 23, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit 3249613 into quarkusio:main May 23, 2023
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels May 23, 2023
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone May 23, 2023
@geoand geoand deleted the #33552 branch May 24, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machi1990 machi1990 machi1990 approved these changes

@radcortez radcortez radcortez approved these changes

Assignees
No one assigned
Labels
kind/bugfix release/breaking-change
Projects
None yet
Milestone
3.2.0.CR1
Development

Successfully merging this pull request may close these issues.

Jib not using image name when using variables
3 participants
@geoand @radcortez @machi1990