Don't ignore invalid config in quarkus.container-image.name

Fixes: #33552
quarkusio · May 23, 2023 · 9129a4d · 9129a4d
1 parent 60a73e1
commit 9129a4d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/.../deployment/src/main/java/io/quarkus/container/image/deployment/ContainerImageConfig.java b/.../deployment/src/main/java/io/quarkus/container/image/deployment/ContainerImageConfig.java
@@ -24,7 +24,7 @@ public class ContainerImageConfig {
      */
     @ConfigItem(defaultValue = "${quarkus.application.name:unset}")
     @ConvertWith(TrimmedStringConverter.class)
-    public Optional<String> name;
+    public String name;
 
     /**
      * The tag of the container image. If not set defaults to the application version

diff --git a/...ployment/src/main/java/io/quarkus/container/image/deployment/ContainerImageProcessor.java b/...ployment/src/main/java/io/quarkus/container/image/deployment/ContainerImageProcessor.java
@@ -89,8 +89,7 @@ public void publishImageInfo(ApplicationInfoBuildItem app,
         }
 
         String effectiveName = containerImageCustomName.map(ContainerImageCustomNameBuildItem::getName)
-                .or(() -> containerImageConfig.name)
-                .orElse(app.getName());
+                .orElse(containerImageConfig.name);
         String repository = (containerImageConfig.getEffectiveGroup().map(s -> s + "/").orElse("")) + effectiveName;
         if (!ImageReference.isValidRepository(repository)) {
             throw new IllegalArgumentException("The supplied combination of container-image group '"