Jib not using image name when using variables

[cescoffier]

Describe the bug

If I use Jib to build a container with the following property (voluntarily without value):

quarkus.container-image.name=hide-and-seek-${application.name}

It ignores the value and uses the artifactId as the default image name.

If I use:

quarkus.container-image.name=hide-and-seek-place-service

It works.

Expected behavior

It should use the set image name, at least try to resolve it, and fails, or at least report something instead of switching silently to the default name.

Actual behavior

It does not.

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

[quarkus-bot]

/cc @geoand (jib)

[geoand]

@cescoffier that's the expected behavior because application.name is not a property that exists.

If you use quarkus.container-image.name=hide-and-seek-${quarkus.application.name} it should work. Can you try?

[cescoffier]

Yes, that's my point; it should NOT go back to the default without telling anything. Either fail (you're dumb - that property does not exist) or replace it using an empty string.

[cescoffier]

(I would prefer a failure - as mandatory properties are ... mandatory)

[geoand]

That's how Smallrye Config works ATM. If we want to change the expected behavior, we would need to make the change there - we would need @radcortez for this.

[cescoffier]

Yes, I agree. At least having a BIG warning telling me that something is wrong and I may do something really wrong (which was the case, as now I've lots of images in my docker registry)

[cescoffier]

BTW, why is this log printed twice?

[INFO] [io.quarkus.container.image.jib.deployment.JibProcessor] Container entrypoint set to [java, -Djava.util.logging.manager=org.jboss.logmanager.LogManager, -jar, quarkus-run.jar]
[INFO] [io.quarkus.container.image.jib.deployment.JibProcessor] Container entrypoint set to [java, -Djava.util.logging.manager=org.jboss.logmanager.LogManager, -jar, quarkus-run.jar]

[geoand]

Dunno, I am not seeing this

[radcortez]

The issue is not with SmallRyeConfig. It is how is mapped.

If you map it as a String and if an expansion value does not exist, you get a NoSuchElementException. If you map it as an Optional<String> and if an expansion value does not exist, you get an empty Optional.

The ConfigRoot is mapped as an Optional:

quarkus/extensions/container-image/deployment/src/main/java/io/quarkus/container/image/deployment/ContainerImageConfig.java

Line 27 in 9e3b813

public Optional<String> name;

And the extension does silently fallback to the application name if there is no value:

quarkus/extensions/container-image/deployment/src/main/java/io/quarkus/container/image/deployment/ContainerImageProcessor.java

Lines 91 to 93 in 177ddeb

	String effectiveName = containerImageCustomName.map(ContainerImageCustomNameBuildItem::getName)
	.or(() -> containerImageConfig.name)
	.orElse(app.getName());

[geoand]

Thanks @radcortez for the analysis!

I'll have a closer look.

[radcortez]

BTW, since the @ConfigRoot sets a default:

quarkus/extensions/container-image/deployment/src/main/java/io/quarkus/container/image/deployment/ContainerImageConfig.java

Lines 25 to 27 in 9e3b813

	@ConfigItem(defaultValue = "${quarkus.application.name:unset}")
	@ConvertWith(TrimmedStringConverter.class)
	public Optional<String> name;

There is not much value in mapping this with an Optional, unless the configuration is explicitly emptied in the configuration with quarkus.container-image.name=.

[geoand]

So if we did:

 @ConfigItem(defaultValue = "${quarkus.application.name:unset}") 
 @ConvertWith(TrimmedStringConverter.class) 
 public String name; 

the expected behavior would be for quarkus.container-image.name=hide-and-seek-${application.name} to fail?

[radcortez]

Yes, you should get a java.util.NoSuchElementException: SRCFG00011: Could not expand value application.name in property quarkus.container-image.name

[geoand]

Understood, thanks for the help.

I opened #33560

[cescoffier]

Wow! Thanks @radcortez for the explanation! It makes sense! We should document that somewhere, as I'm sure lots of extension author do not see the difference of behavior!

[geoand]

+100 for documenting it!