Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move native Resource configuration from Feature to json #31185

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Feb 15, 2023

Follow up to #29886

@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Feb 17, 2023

@zakkak could you rebase? It conflicts with the previous one I merged.

@zakkak zakkak force-pushed the 2023-02-15-resource-config-json branch 3 times, most recently from d4f7605 to 54da87a Compare February 17, 2023 12:34
@quarkus-bot

This comment has been minimized.

@zakkak zakkak force-pushed the 2023-02-15-resource-config-json branch from 54da87a to 982b734 Compare February 17, 2023 13:00
@quarkus-bot

This comment has been minimized.

@zakkak zakkak force-pushed the 2023-02-15-resource-config-json branch from 982b734 to b7f49dd Compare February 20, 2023 13:41
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 20, 2023

Failing Jobs - Building b7f49dd

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/resteasy-classic/resteasy/deployment 
! Skipped: extensions/agroal/deployment extensions/avro/deployment extensions/cache/deployment and 301 more

📦 extensions/resteasy-classic/resteasy/deployment

io.quarkus.resteasy.test.config.ProviderConfigInjectionWarningsTest. line 39 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <4> but was: <5>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

@zakkak
Copy link
Contributor Author

zakkak commented Feb 21, 2023

The failure seems unrelated, I also can't reproduce it locally and more interestingly the unit tests fails because if detects 5 warnings while I only see 4 :/

Anyway, labeling this as flaky-test and merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants