-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native image - Correct Windows paths in resources #31308
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
This comment has been minimized.
This comment has been minimized.
@@ -13,6 +13,7 @@ | |||
public class ResourceHelper { | |||
|
|||
public static void registerResources(String resource) { | |||
resource = resource.replace('\\', '/')); // correct Windows paths |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this probably fixes it but why is the resource using non portable paths to begin with? should be platform neutral before it gets here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, this doesn't seem right. We should tackle this earlier. At this point the path has already been written by Quarkus to a txt file and parsed in the wrong format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You guys are the experts 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zakkak will you have a look at this issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but the sooner I will probably be able to have a look at it will be late next week.
In the meantime, #31185 is now merged, @melloware could you please confirm the issue is still present in Quarkus main
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am running on 2.16.3 not on SNAPSHOT so I have not confirmed it in main yet. Will try to get to it.
Agreed! But it's outside my depth of knowledge of why it's wrong when it gets here. |
@zakkak I will drive this issue to a conclusion in #31307 |
@Karm would you like me to close this PR? |
This is not the root cause for Quarkus Native Primefaces Windows problems. Let me close the PR now.
Both Podman and Docker though get stuck on a locked logfile target/quarkus.log. So that's what I am looking into now. |
Great work. I think there will also be a bunch of open Native Windows tickets you can close here too once done as I found about 3-4 issues that I am pretty sure are already fixed. |
Fix #31307: Correct Windows paths in native image