Fix resource registration for native compilation #40184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NativeImageResourceBuildItem and ServiceProviderBuildItem contain a path of the resource we should include and not a pattern or a glob. As a result, `Pattern.quote` is the right method to use in order to produce a pattern that would match the path. The patch also remove the wrong addition of the paths "as is" to the includes json array. Fix up of b7f49dd
gastaldi
approved these changes
Apr 22, 2024
dmlloyd
approved these changes
Apr 22, 2024
gastaldi
added
the
triage/waiting-for-ci
mkouba
reviewed
Apr 22, 2024
Done in 24507ee |
This comment has been minimized.
This comment has been minimized.
zakkak
force-pushed
the
2024-04-22-fix-double-resource-registration
branch
2 times, most recently
from
98552ea to
24507ee
Compare
gsmet
approved these changes
Apr 22, 2024
mkouba
reviewed
Apr 22, 2024
.../src/main/java/io/quarkus/deployment/builditem/nativeimage/NativeImageResourceBuildItem.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
zakkak
force-pushed
the
2024-04-22-fix-double-resource-registration
branch
from
24507ee to
757537b
Compare
Status for workflow
|
mkouba
approved these changes
Apr 23, 2024
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NativeImageResourceBuildItem and ServiceProviderBuildItem contain a path
of the resource we should include and not a pattern or a glob. As a
result,
Pattern.quoteis the right method to use in order to produce apattern that would match the path.
The patch also remove the wrong addition of the paths "as is" to the
includes json array.
Fix up of b7f49dd (#31185)