Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse the build executor thread pool for parallel execution #27159

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Aug 5, 2022

  • for class transformation and ArC resource generation
  • previously separate executor services were created and shut down

- for class transformation and ArC resource generation
- previously separate executor services were created and shut down
@mkouba mkouba requested a review from geoand August 5, 2022 14:45
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/core labels Aug 5, 2022
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@mkouba
Copy link
Contributor Author

mkouba commented Aug 8, 2022

@manovotn this intermittent failure might be related to #26968.

@quarkus-bot

This comment has been minimized.

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 8, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 8, 2022

Failing Jobs - Building efe6397

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 18 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 18 #

- Failing: extensions/smallrye-reactive-messaging-kafka/deployment 
! Skipped: integration-tests/kafka-oauth-keycloak integration-tests/kafka-sasl-elytron integration-tests/kubernetes/quarkus-standard-way-kafka and 3 more

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario2 line 83 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Failed to wait for test run 4 State{lastRun=3, running=true, inProgress=true, run=1, passed=0, failed=1, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true}
	at io.quarkus.test.ContinuousTestingTestUtils.waitForNextCompletion(ContinuousTestingTestUtils.java:44)
	at io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario2(KafkaDevServicesContinuousTestingTestCase.java:83)

@mkouba
Copy link
Contributor Author

mkouba commented Aug 8, 2022

I'm going to merge this PR. CI failures are not related.

@mkouba mkouba merged commit 565dc63 into quarkusio:main Aug 8, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Aug 8, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 8, 2022
@manovotn
Copy link
Contributor

@manovotn this intermittent failure might be related to #26968.

This is true, I think the assertion can come too early since there can be a race condition.
PR incoming shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants