Context propagation - cleared Arc snapshot should destroy its state once the invocation ends #26968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manovotn
added
area/arc
This comment was marked as outdated.
This comment was marked as outdated.
manovotn
changed the title
mkouba
reviewed
Jul 28, 2022
extensions/arc/runtime/src/main/java/io/quarkus/arc/runtime/context/ArcContextProvider.java
Outdated
Show resolved
Hide resolved
…nce the invocation ends
manovotn
force-pushed
the
cpClearContextIssue
branch
from
cd48537 to
d75ab66
Compare
|
This is IMO more of an Arc/CDI question than CP itself plus Stef is not currently around. |
mkouba
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to a Zulip thread discussion.
A quick sum up is that this focuses on a scenario where used specifically wants to execute action(s) that will not propagate Arc context and wants a new context instead. This is supported by MP CP. However, in our code, we never destroy any instances created in this new context before we restore previous state which I think is incorrect. However I might be missing some other case where destroying them might be a bad move?
The PR has the needed code adjustment plus a test hopefully showing exactly what I mean with the description above^
Ccing @mkouba and @Ladicek whom I discussed this with. Thoughts, ideas, counterexamples? :)