Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix intermittent failure in SimpleContextPropagationTest caused by possible race condition #27284

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

manovotn
Copy link
Contributor

As per comment in #27159 (comment), one of the CP tests can have a race condition. Using CountDownLatch to force await for bean destruction should fix this.

@manovotn manovotn requested a review from mkouba August 15, 2022 12:46
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 15, 2022
@gastaldi gastaldi merged commit 81e4ecb into quarkusio:main Aug 15, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Aug 15, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 15, 2022
@manovotn manovotn deleted the failingCpTest branch August 15, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants