-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce @WithOpenShiftTestServer annotation #18929
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
...ntime-internal/src/main/java/io/quarkus/kubernetes/client/runtime/KubernetesClientUtils.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
8187e8e
to
aaf892a
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building aaf892a
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/kubernetes-client✖
✖
✖
✖
✖
✖
✖
✖
⚙️ JVM Tests - JDK 11 Windows #📦 integration-tests/kubernetes-client✖
✖
✖
✖
✖
✖
✖
✖
⚙️ JVM Tests - JDK 16 #📦 integration-tests/kubernetes-client✖
✖
✖
✖
✖
✖
✖
✖
|
aaf892a
to
26527c6
Compare
26527c6
to
394cd7f
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 394cd7f
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/kubernetes-client✖
⚙️ JVM Tests - JDK 11 Windows #📦 integration-tests/kubernetes-client✖
⚙️ JVM Tests - JDK 16 #📦 integration-tests/kubernetes-client✖
|
Allows to easily run QuarkusTests with OpenShiftMockserver Signed-off-by: Marc Nuri <[email protected]>
394cd7f
to
4423212
Compare
This PR provides a new
@WithOpenShiftTestServer
with similar behavior as@WithKubernetesTestServer
.Some work was already performed by @geoand in scope of #18698 (#18714). I hope this doesn't collide with any pending/active work.
See internal discussion for additional reference: https://chat.google.com/room/AAAAbhT8H5E/uA8h84eEi_g
This implementation allows creating a test such as:
Notes
https
.I've included a fix for this
Relates to: