Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OpenShiftConfig missing some configurations from provided Config #3347

Merged
merged 1 commit into from
Jul 23, 2021
Merged

fix: OpenShiftConfig missing some configurations from provided Config #3347

merged 1 commit into from
Jul 23, 2021

Conversation

manusa
Copy link
Member

@manusa manusa commented Jul 22, 2021 •
edited
Loading

Description

fix: OpenShiftConfig missing some configurations from provided Config

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@centos-ci
Copy link

Can one of the admins verify this patch?

@manusa manusa requested a review from rohanKanojia July 22, 2021 09:19
@manusa manusa added this to the 5.7.0 milestone Jul 22, 2021
@manusa manusa mentioned this pull request Jul 22, 2021
Merged
@manusa manusa force-pushed the fix/incomplete-openshift-config branch from 3b2ff98 to 7ba675b Compare July 23, 2021 04:27
@manusa manusa self-assigned this Jul 23, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@rohanKanojia rohanKanojia requested a review from shawkins July 23, 2021 06:08
@manusa manusa merged commit 93d3f01 into fabric8io:master Jul 23, 2021
@manusa manusa deleted the fix/incomplete-openshift-config branch July 23, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@oscerd oscerd oscerd approved these changes

@shawkins shawkins Awaiting requested review from shawkins

Assignees

@manusa manusa

Labels
None yet
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@manusa @centos-ci @oscerd @rohanKanojia