Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up template URI matching; add support for servlets #15047

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Clean up template URI matching; add support for servlets #15047

merged 1 commit into from
Apr 1, 2021

Conversation

ebullient
Copy link
Member

@ebullient ebullient commented Feb 12, 2021 •
edited
Loading

Addresses part of #15044 (servlets)

This cleans up some path processing (consistent w/ 2.0 branch, and what I've been carting around with many attempts at this).

@geoand
Copy link
Contributor

geoand commented Feb 12, 2021

I'm gonna let Stuart review this one as I haven't seen worked with that part of the code

@ebullient
Copy link
Member Author

/cc @hacst =)

stuartwdouglas
stuartwdouglas previously requested changes Feb 15, 2021
View reviewed changes
Copy link
Member

@stuartwdouglas stuartwdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, for Servlet can you just call HttpServletRequest#getServletPath ? It should return the matched path.

...java/io/quarkus/micrometer/runtime/binder/vertx/VertxMeterBinderRestEasyContainerFilter.java Outdated Show resolved Hide resolved
...asy-common/runtime/src/main/java/io/quarkus/resteasy/common/runtime/MethodFullPathIndex.java Outdated Show resolved Hide resolved
This was referenced Feb 22, 2021
Closed
Closed
@quarkus-bot quarkus-bot bot added area/vertx area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/rest labels Mar 5, 2021
@ebullient ebullient mentioned this pull request Mar 10, 2021
Closed
@ebullient ebullient requested a review from kenfinnigan March 11, 2021 16:48
Base automatically changed from master to main March 12, 2021 15:55
@ebullient ebullient marked this pull request as ready for review April 1, 2021 05:02
@ebullient ebullient changed the title WIP First pass at better template URI matching Clean up template URI matching; add support for servlets Apr 1, 2021
@ebullient ebullient added area/undertow and removed area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/resteasy-classic area/rest labels Apr 1, 2021
@ebullient ebullient merged commit f47558a into quarkusio:main Apr 1, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Apr 1, 2021
@ebullient ebullient deleted the templateUri branch April 1, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenfinnigan kenfinnigan kenfinnigan approved these changes

@stuartwdouglas stuartwdouglas stuartwdouglas left review comments

@geoand geoand Awaiting requested review from geoand

Assignees
No one assigned
Labels
area/metrics area/undertow area/vertx
Projects
None yet
Milestone
2.0.0.Alpha1
Development

Successfully merging this pull request may close these issues.
4 participants
@ebullient @geoand @stuartwdouglas @kenfinnigan