Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better detection of rest request templated paths for metrics (micrometer) #15044

Closed
ebullient opened this issue Feb 12, 2021 · 1 comment · Fixed by #17676
Closed

Better detection of rest request templated paths for metrics (micrometer) #15044

ebullient opened this issue Feb 12, 2021 · 1 comment · Fixed by #17676

Comments

@ebullient
Copy link
Member

Description
Follow on from #14813

Using matchPattern to replace the URI used with http metrics tags is error prone. The existing detection mechanism was cursory, and only worked for simple paths.

Implementation ideas

For ResteasyReactive, we have a chance to expose the known/used template path more directly as part of the SimplifiedResourceInfo associated with the RuntimeResource. We can still hide a lot of the gorpy details while providing a reasonable String representation of the matched URI.

For older Resteasy, this is harder, and a bit more expensive to find the bits required to put the URI together.

For undertow.... yuck? (still thinking about it)

@ebullient ebullient added the kind/enhancement New feature or request label Feb 12, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 12, 2021

/cc @jmartisk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants