-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client Metrics does not use template URI variables #15231
Comments
/cc @jmartisk |
I have an existing PR in flight for improved URI templating, #15047 To handle this in the meanwhile, you can set a match pattern: |
Thank you! Quarkus version is the 1.12.0.Final, the extensions are this ones:
I took them from the "Installed features" log at the start, is it ok? The implementation of the Client is the class I saw your PR but didn t thought was for rest clients too tbh |
It isn't, yet. ;) |
I broke #15047 apart in the end. Will use this to track rest client support after all. |
Description
Client Metrics does not use template URI variable for the called api.
instead of having one metric:
http_client_requests_seconds_count{.... status="200",uri="/api/v1/surveys/{surveyId}",} 5.0
there are multiple metrics:
http_client_requests_seconds_count{.... status="200",uri="/api/v1/surveys/387",} 3.0
http_client_requests_seconds_count{.... status="200",uri="/api/v1/surveys/388",} 2.0
I don't think it's the correct behavior, it should probably works like the server metrics.
I did a very little debugging (i m not very familiar with the code), and the problem seems in the HttpRequestMetric, the
routingContext
variable is null, so he ll just return the complete path.It may be a problem with my dependencies?
Thanks
The text was updated successfully, but these errors were encountered: