Rework constrained method inheritance for Hibernate Validator extension #13529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
famod
approved these changes
Nov 27, 2020
...ent/src/main/java/io/quarkus/hibernate/validator/deployment/HibernateValidatorProcessor.java
Outdated
Show resolved
Hide resolved
...in/java/io/quarkus/hibernate/validator/deployment/MethodValidatedAnnotationsTransformer.java
Outdated
Show resolved
Hide resolved
...in/java/io/quarkus/hibernate/validator/deployment/MethodValidatedAnnotationsTransformer.java
Outdated
Show resolved
Hide resolved
gsmet
force-pushed
the
rework-inheritance
branch
from
ef6d8b0 to
253cf9b
Compare
|
Thanks. Apparently too late to do some proper coding :). Yeah I think it will also solve #11536. |
gsmet
force-pushed
the
rework-inheritance
branch
from
253cf9b to
ddea520
Compare
|
@geoand could you have a look to that one? It's a good candidate for 1.10.2. |
machi1990
approved these changes
Nov 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13470
Fixes #11536
@famod IIRC you were the last person working on this. I decided to rework it to exploit the index to get all the information rather than having a not so good way to manage the interface in the annotation transformer.
Let me know what you think.