Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hibernate Validator: Consider all superclasses when checking for annotations and add tests #11536

Closed
famod opened this issue Aug 21, 2020 · 1 comment · Fixed by #13529
Closed
Labels
area/hibernate-validator Hibernate Validator kind/enhancement New feature or request
Milestone

Comments

@famod
Copy link
Member

famod commented Aug 21, 2020

Description
In #11506 (which had another/smaller scope initially) I extended the transformer to look for validation and/or JAX-RS annotations also in the direct superclass.
Theoretically, this is an incomplete solution - the entire hierarchy has to be checked instead.
#11506 did also not add any superclass tests.

Update, idea from @gsmet (discussed via private messages on Zulip):

you would do everything in the processor
by registering keys for the subclasses/implementations
going down the hierarchy in the processor
instead of having to go up in the transformer

@famod famod added the kind/enhancement New feature or request label Aug 21, 2020
@quarkusbot quarkusbot added the area/hibernate-validator Hibernate Validator label Aug 21, 2020
@quarkusbot
Copy link

/cc @gsmet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-validator Hibernate Validator kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants