We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug quarkus-hibernate-validator does not work if class implements a resource interface that extends another interface.
quarkus-hibernate-validator
public interface BookResource { String PATH = "/books"; @GET @Produces(MediaType.TEXT_PLAIN) String hello(@NotNull @QueryParam("name") String name); } @Path(ScienceBookResource.PATH) public interface ScienceBookResource extends BookResource { String PATH = BookResource.PATH + "/science"; } public class ScienceBookResourceImpl implements ScienceBookResource { @Override public String hello(String name) { return "Hello " + name; } }
This used to work in Quarkus 1.6.2 but seems to be broken in some of the higher versions.
Expected behavior quarkus-hibernate-validator should correctly validate even such resources.
Actual behavior quarkus-hibernate-validator does not validate even such resources.
To Reproduce
git clone [email protected]:Meemaw/quarkus-validation-bug.git quarkus-reproducer-hibernate cd quarkus-reproducer-hibernate ./mvnw quarkus:dev
Go to: http://localhost:8080/books/science
You will see: Hello null
Hello null
What should happen: Validation error is thrown
Environment (please complete the following information):
java -version
The text was updated successfully, but these errors were encountered:
/cc @gsmet
Sorry, something went wrong.
Rework constrained method inheritance for Hibernate Validator extension
ef6d8b0
Fixes quarkusio#13470
Thanks for the detailed report and the reproducer.
I created #13529 to fix it.
253cf9b
Great, thanks @gsmet. Does this by any change also fixes #13029? It seems related.
ddea520
4f2915c
gsmet
Successfully merging a pull request may close this issue.
Describe the bug
quarkus-hibernate-validator
does not work if class implements a resource interface that extends another interface.This used to work in Quarkus 1.6.2 but seems to be broken in some of the higher versions.
Expected behavior
quarkus-hibernate-validator
should correctly validate even such resources.Actual behavior
quarkus-hibernate-validator
does not validate even such resources.To Reproduce
Go to: http://localhost:8080/books/science
You will see:
Hello null
What should happen: Validation error is thrown
Environment (please complete the following information):
java -version
: openjdk version "15.0.1" 2020-10-20The text was updated successfully, but these errors were encountered: